Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751476AbdFGKcL (ORCPT ); Wed, 7 Jun 2017 06:32:11 -0400 Received: from smtp.eu.citrix.com ([185.25.65.24]:4818 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066AbdFGKcK (ORCPT ); Wed, 7 Jun 2017 06:32:10 -0400 X-IronPort-AV: E=Sophos;i="5.39,310,1493683200"; d="scan'208";a="47344136" Subject: Re: [PATCH V2] xen-evtchn: Bind dyn evtchn:qemu-dm interrupt to next online VCPU To: Boris Ostrovsky , , CC: References: <1496746648-25300-1-git-send-email-anoob.soman@citrix.com> <91bfac47-7258-cec0-2a61-29f2b2e5454b@oracle.com> From: Anoob Soman Message-ID: Date: Wed, 7 Jun 2017 11:31:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <91bfac47-7258-cec0-2a61-29f2b2e5454b@oracle.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-ClientProxiedBy: FTLPEX02CAS04.citrite.net (10.13.99.237) To AMSPEX02CL02.citrite.net (10.69.22.126) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 339 Lines: 15 On 06/06/17 20:41, Boris Ostrovsky wrote: > > There is a single call site for rebind_irq_to_cpu() so why not call > xen_rebind_evtchn_to_cpu() directly? > Fair enough, I will change it. > >> + raw_spin_lock_irqsave(&desc->lock, flags); > Is there a reason why you are using raw_ version? desc->lock is defined as raw_spinlock_t -Anoob