Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751507AbdFGKqk (ORCPT ); Wed, 7 Jun 2017 06:46:40 -0400 Received: from mail-qt0-f178.google.com ([209.85.216.178]:34951 "EHLO mail-qt0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751206AbdFGKqi (ORCPT ); Wed, 7 Jun 2017 06:46:38 -0400 MIME-Version: 1.0 In-Reply-To: <20170607101832.GW30622@linux-l9pv.suse> References: <20170607060527.23407-1-jlee@suse.com> <20170607101832.GW30622@linux-l9pv.suse> From: Andy Shevchenko Date: Wed, 7 Jun 2017 13:46:37 +0300 Message-ID: Subject: Re: [PATCH] acpi: handle the acpi hotplug schedule error To: joeyli Cc: "Lee, Chun-Yi" , "Rafael J . Wysocki" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Len Brown Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1268 Lines: 48 On Wed, Jun 7, 2017 at 1:18 PM, joeyli wrote: > On Wed, Jun 07, 2017 at 11:36:55AM +0300, Andy Shevchenko wrote: >> On Wed, Jun 7, 2017 at 9:05 AM, Lee, Chun-Yi wrote: >> > Kernel should decrements the reference count of acpi device >> > when scheduling acpi hotplug work is failed, and also evaluates >> > _OST to notify BIOS the failure. > So, do you mean like this? Yes, see below. > > - if (hotplug_event && ACPI_SUCCESS(acpi_hotplug_schedule(adev, type))) > - return; > + if (hotplug_event) { > + if (ACPI_SUCCESS(acpi_hotplug_schedule(adev, type))) > + return; > + else It's redundant... > + goto err_put_device; ...perhaps if (ACPI_FAILURE(acpi_hotplug_schedule(adev, type))) goto err_put_device; return; > + } > > acpi_bus_put_acpi_device(adev); > return; > > +err_put_device: > + acpi_bus_put_acpi_device(adev); > err: > acpi_evaluate_ost(handle, type, ost_code, NULL); > } -- With Best Regards, Andy Shevchenko