Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751612AbdFGK5v (ORCPT <rfc822;w@1wt.eu>);
        Wed, 7 Jun 2017 06:57:51 -0400
Received: from mail-wr0-f169.google.com ([209.85.128.169]:35777 "EHLO
        mail-wr0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751562AbdFGK5t (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 7 Jun 2017 06:57:49 -0400
Subject: Re: [PATCH 2/2] video: adp8870: move header file out of I2C realm
To: Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org
Cc: Steven Miao <realmz6@gmail.com>, Lee Jones <lee.jones@linaro.org>,
        Jingoo Han <jingoohan1@gmail.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        adi-buildroot-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org
References: <20170521220953.2602-1-wsa@the-dreams.de>
 <20170521220953.2602-3-wsa@the-dreams.de>
From: Daniel Thompson <daniel.thompson@linaro.org>
Message-ID: <3fff4554-8f66-064c-3760-8d5fc701fbe5@linaro.org>
Date: Wed, 7 Jun 2017 11:57:45 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <20170521220953.2602-3-wsa@the-dreams.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1757
Lines: 46

On 21/05/17 23:09, Wolfram Sang wrote:
> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

Acked-by: Daniel Thompson <daniel.thompson@linaro.org>

> ---
>   arch/blackfin/mach-bf537/boards/stamp.c        | 2 +-
>   drivers/video/backlight/adp8870_bl.c           | 2 +-
>   include/linux/{i2c => platform_data}/adp8870.h | 0
>   3 files changed, 2 insertions(+), 2 deletions(-)
>   rename include/linux/{i2c => platform_data}/adp8870.h (100%)
> 
> diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
> index 7db90c72bd8ddc..7528148dc4925b 100644
> --- a/arch/blackfin/mach-bf537/boards/stamp.c
> +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> @@ -1995,7 +1995,7 @@ static struct adp5588_gpio_platform_data adp5588_gpio_data = {
>   #endif
>   
>   #if IS_ENABLED(CONFIG_BACKLIGHT_ADP8870)
> -#include <linux/i2c/adp8870.h>
> +#include <linux/platform_data/adp8870.h>
>   static struct led_info adp8870_leds[] = {
>   	{
>   		.name = "adp8870-led7",
> diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c
> index 21acac90fd773f..058d1def2d1f4b 100644
> --- a/drivers/video/backlight/adp8870_bl.c
> +++ b/drivers/video/backlight/adp8870_bl.c
> @@ -18,7 +18,7 @@
>   #include <linux/workqueue.h>
>   #include <linux/slab.h>
>   
> -#include <linux/i2c/adp8870.h>
> +#include <linux/platform_data/adp8870.h>
>   #define ADP8870_EXT_FEATURES
>   #define ADP8870_USE_LEDS
>   
> diff --git a/include/linux/i2c/adp8870.h b/include/linux/platform_data/adp8870.h
> similarity index 100%
> rename from include/linux/i2c/adp8870.h
> rename to include/linux/platform_data/adp8870.h
>