Reply-To: <michael.hennerich@analog.com>
Subject: Re: [PATCH 1/2] video: adp8860: move header file out of I2C realm
To: Daniel Thompson <daniel.thompson@linaro.org>,
        Wolfram Sang <wsa@the-dreams.de>, <linux-i2c@vger.kernel.org>
CC: Steven Miao <realmz6@gmail.com>, Lee Jones <lee.jones@linaro.org>,
        "Jingoo Han" <jingoohan1@gmail.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        <adi-buildroot-devel@lists.sourceforge.net>,
        <linux-kernel@vger.kernel.org>, <linux-fbdev@vger.kernel.org>
References: <20170521220953.2602-1-wsa@the-dreams.de>
 <20170521220953.2602-2-wsa@the-dreams.de>
 <d66d5331-7b9b-9b7d-fb24-b148dcc41673@linaro.org>
From: Michael Hennerich <michael.hennerich@analog.com>
Organization: Analog Devices Inc.
Message-ID: <cf602505-7bf3-8f10-0517-1eee42a5b0c2@analog.com>
Date: Wed, 7 Jun 2017 14:10:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <d66d5331-7b9b-9b7d-fb24-b148dcc41673@linaro.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2017 12:09:01.5715
 (UTC)
X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.55];Helo=[nwd2mta1.analog.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR03MB188
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2154
Lines: 63

On 07.06.2017 12:57, Daniel Thompson wrote:
> On 21/05/17 23:09, Wolfram Sang wrote:
>> include/linux/i2c is not for client devices. Move the header file to a
>> more appropriate location.
>>
>> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> 
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

> 
>> ---
>>   arch/blackfin/mach-bf537/boards/stamp.c        | 2 +-
>>   drivers/video/backlight/adp8860_bl.c           | 2 +-
>>   include/linux/{i2c => platform_data}/adp8860.h | 0
>>   3 files changed, 2 insertions(+), 2 deletions(-)
>>   rename include/linux/{i2c => platform_data}/adp8860.h (100%)
>>
>> diff --git a/arch/blackfin/mach-bf537/boards/stamp.c 
>> b/arch/blackfin/mach-bf537/boards/stamp.c
>> index 24985e658c19cd..7db90c72bd8ddc 100644
>> --- a/arch/blackfin/mach-bf537/boards/stamp.c
>> +++ b/arch/blackfin/mach-bf537/boards/stamp.c
>> @@ -2047,7 +2047,7 @@ static struct adp8870_backlight_platform_data 
>> adp8870_pdata = {
>>   #endif
>>   #if IS_ENABLED(CONFIG_BACKLIGHT_ADP8860)
>> -#include <linux/i2c/adp8860.h>
>> +#include <linux/platform_data/adp8860.h>
>>   static struct led_info adp8860_leds[] = {
>>       {
>>           .name = "adp8860-led7",
>> diff --git a/drivers/video/backlight/adp8860_bl.c 
>> b/drivers/video/backlight/adp8860_bl.c
>> index 510e559c060e59..e7315bf14d6015 100644
>> --- a/drivers/video/backlight/adp8860_bl.c
>> +++ b/drivers/video/backlight/adp8860_bl.c
>> @@ -18,7 +18,7 @@
>>   #include <linux/slab.h>
>>   #include <linux/workqueue.h>
>> -#include <linux/i2c/adp8860.h>
>> +#include <linux/platform_data/adp8860.h>
>>   #define ADP8860_EXT_FEATURES
>>   #define ADP8860_USE_LEDS
>> diff --git a/include/linux/i2c/adp8860.h 
>> b/include/linux/platform_data/adp8860.h
>> similarity index 100%
>> rename from include/linux/i2c/adp8860.h
>> rename to include/linux/platform_data/adp8860.h
>>
> 
> 


-- 
Greetings,
Michael

--
Analog Devices GmbH      Otl-Aicher Strasse 60-64      80807 München
Sitz der Gesellschaft München, Registergericht München HRB 40368,
Geschäftsführer: Peter Kolberg, Ali Raza Husain, Eileen Wynne