Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751478AbdFGMmq (ORCPT ); Wed, 7 Jun 2017 08:42:46 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:35822 "EHLO mail-it0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbdFGMmo (ORCPT ); Wed, 7 Jun 2017 08:42:44 -0400 MIME-Version: 1.0 X-Originating-IP: [149.6.131.75] In-Reply-To: References: <20170523133448.4794-1-javier@dowhile0.org> <20170523133448.4794-13-javier@dowhile0.org> From: Javier Martinez Canillas Date: Wed, 7 Jun 2017 14:42:43 +0200 Message-ID: Subject: Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible string for I2C EEPROM To: Masahiro Yamada Cc: Linux Kernel Mailing List , Wolfram Sang , Rob Herring , "devicetree@vger.kernel.org" , Rob Herring , Mark Rutland , Russell King , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 889 Lines: 33 Hello Masahiro, On Wed, Jun 7, 2017 at 3:10 AM, Masahiro Yamada wrote: [snip] >>> >>> Why didn't you touch >>> arch/arm/boot/dts/uniphier-ref-daughter.dtsi ? >>> >> >> Because the compatible string "microchip,24lc128" used by the I2C >> EEPROM node on that DTS is not supported by the >> drivers/misc/eeprom/at24.c driver (in fact the only occurrence for >> 24lc128 I see is in that DTS). >> >> Maybe is a typo and it should be "microchip,24c128" instead ? > > I do not think so. > I consulted a board developer. > > I also see 24LC128 on Microchip web site: > http://www.microchip.com/wwwproducts/en/24LC128 > Ah Ok, it was just a wild guess I did since the at24 driver didn't have support for this chip variant. My point stands though, this is an unrelated change to the goal of this patch-series and should be fixed separately. Best regards, Javier