Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751731AbdFGNxE (ORCPT ); Wed, 7 Jun 2017 09:53:04 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:21550 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490AbdFGNxC (ORCPT ); Wed, 7 Jun 2017 09:53:02 -0400 Date: Wed, 7 Jun 2017 09:52:34 -0400 From: Konrad Rzeszutek Wilk To: Steven Haigh Cc: xen-devel@lists.xen.org, Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, roger.pau@citrix.com Subject: Re: [Xen-devel] [PATCH v2 0/3] xen/blkback: several fixes of resource management Message-ID: <20170607135234.GE31454@char.us.oracle.com> References: <20170518152849.1872-1-jgross@suse.com> <1519306.ELMa8d1Tnk@dhcp-10-1-1-124.lan.crc.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1519306.ELMa8d1Tnk@dhcp-10-1-1-124.lan.crc.id.au> User-Agent: Mutt/1.8.0 (2017-02-23) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1418 Lines: 38 On Wed, Jun 07, 2017 at 10:36:58PM +1000, Steven Haigh wrote: > On Friday, 19 May 2017 1:28:46 AM AEST Juergen Gross wrote: > > Destroying a Xen guest domain while it was doing I/Os via xen-blkback > > leaked several resources, including references of the guest's memory > > pages. > > > > This patch series addresses those leaks by correcting usage of > > reference counts and the sequence when to free which resource. > > > > The series applies on top of commit 2d4456c73a487abe ("block: > > xen-blkback: add null check to avoid null pointer dereference") in > > Jens Axboe's tree kernel/git/axboe/linux-block.git > > > > V2: changed flag to type bool in patch 1 (Dietmar Hahn) > > > > Juergen Gross (3): > > xen/blkback: fix disconnect while I/Os in flight > > xen/blkback: don't free be structure too early > > xen/blkback: don't use xen_blkif_get() in xen-blkback kthread > > > > drivers/block/xen-blkback/blkback.c | 3 --- > > drivers/block/xen-blkback/common.h | 1 + > > drivers/block/xen-blkback/xenbus.c | 15 ++++++++------- > > 3 files changed, 9 insertions(+), 10 deletions(-) > > Just wanted to give this a bit of a prod. Ouch! > > Is there any plans in having this hit the kernel.org kernels? Yes. > > My testing was purely on kernel 4.9 branch - but it doesn't look like this has > shown up there yet? Correct. I am thinking to send these to Jens around June 20th or so.