Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751610AbdFGOIP (ORCPT ); Wed, 7 Jun 2017 10:08:15 -0400 Received: from mail.crc.id.au ([203.56.246.92]:39102 "EHLO mail.crc.id.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751473AbdFGOIO (ORCPT ); Wed, 7 Jun 2017 10:08:14 -0400 From: Steven Haigh To: Konrad Rzeszutek Wilk , Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, roger.pau@citrix.com Subject: Re: [Xen-devel] [PATCH v2 0/3] xen/blkback: several fixes of resource management Date: Thu, 08 Jun 2017 00:08:06 +1000 Message-ID: <4471350.0PseRmCbC0@dhcp-10-1-1-124.lan.crc.id.au> In-Reply-To: <20170607135234.GE31454@char.us.oracle.com> References: <20170518152849.1872-1-jgross@suse.com> <1519306.ELMa8d1Tnk@dhcp-10-1-1-124.lan.crc.id.au> <20170607135234.GE31454@char.us.oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart8569853.cRMWXsi7qV"; micalg="pgp-sha256"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3139 Lines: 79 --nextPart8569853.cRMWXsi7qV Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" On Wednesday, 7 June 2017 11:52:34 PM AEST Konrad Rzeszutek Wilk wrote: > On Wed, Jun 07, 2017 at 10:36:58PM +1000, Steven Haigh wrote: > > On Friday, 19 May 2017 1:28:46 AM AEST Juergen Gross wrote: > > > Destroying a Xen guest domain while it was doing I/Os via xen-blkback > > > leaked several resources, including references of the guest's memory > > > pages. > > >=20 > > > This patch series addresses those leaks by correcting usage of > > > reference counts and the sequence when to free which resource. > > >=20 > > > The series applies on top of commit 2d4456c73a487abe ("block: > > > xen-blkback: add null check to avoid null pointer dereference") in > > > Jens Axboe's tree kernel/git/axboe/linux-block.git > > >=20 > > > V2: changed flag to type bool in patch 1 (Dietmar Hahn) > > >=20 > > > Juergen Gross (3): > > > xen/blkback: fix disconnect while I/Os in flight > > > xen/blkback: don't free be structure too early > > > xen/blkback: don't use xen_blkif_get() in xen-blkback kthread > > > =20 > > > drivers/block/xen-blkback/blkback.c | 3 --- > > > drivers/block/xen-blkback/common.h | 1 + > > > drivers/block/xen-blkback/xenbus.c | 15 ++++++++------- > > > 3 files changed, 9 insertions(+), 10 deletions(-) > >=20 > > Just wanted to give this a bit of a prod. >=20 > Ouch! >=20 > > Is there any plans in having this hit the kernel.org kernels? >=20 > Yes. >=20 > > My testing was purely on kernel 4.9 branch - but it doesn't look like t= his > > has shown up there yet? >=20 > Correct. I am thinking to send these to Jens around June 20th or so. Ok, all understood. Thanks for the clarifications. At the moment, I'm just including them in my kernel builds - then expecting= =20 them to fail at one point in the future when the patch fails due to=20 upstreaming. I'll just keep doing this. =2D-=20 Steven Haigh =F0=9F=93=A7 netwiz@crc.id.au =F0=9F=92=BB http://www.crc.id.au =F0=9F=93=9E +61 (3) 9001 6090 =F0=9F=93=B1 0412 935 897 --nextPart8569853.cRMWXsi7qV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEFHf0gfgNrH6ofcYGQa811Xp9MdwFAlk4CMYACgkQQa811Xp9 MdyJSw/+OYsGwB7d+aeYH3a4xxDtWzxDaTLQ9b+P57375+kV64GS7+pd2RrXxKVQ M6EznXuRXFlzygn+EctIX3aBnbL3vyZlcZfR3sK+zi2gGdUoapFUASXqmGDSdOAy bC5tHVeFkjZkevIl/AMF5CBEOymYnxj2Uv7aedwog9WKrF4YcI1ZLoSHfScmXfoh t3sTgw815SoLG3cV6/QhuWFRYS568fZX/koroKxJz3qZ2rabd40AAn+ADlWjxLmT tj1fSaKstn6eeYfsOf2rcpXrvnvm96wH4yLNZzYg1XtD34vH0Mt1LSC+H8HnyTFM yf3aQPQvJPT5yWoJpT/KPRXMXx5TGeAbgayI9z9k/uyX2M3vLg7k284q4JtItkWZ VUv7G7GhDV2YQbMhqHPtkZ+7Zt4aoNPkYMUYQSCoKUeXLoxJZjIwYArrWD2IJFmb j4rTOEQKpoMoplrVGEPxm1r3ob16nhWXpVXW5DQ/H1haUzWLvoj//LPavrS9wzPA 8CF6/D9dzXwuTOnyBG36DT5zIpFyYIBCh5h+VUAZx8DdEOmbUmOohQ5dzbCxN2aU PN/WDFEIkLqu8Q2sBwKAC0/QipgbU864oPiH2S7yWiddQTsG46owqTK9SqDaTDDA s91hEx7ce1eR0v7yA47uPlkjdD+wWlaGFSOMAdn8FiOeuchGxEw= =mc6m -----END PGP SIGNATURE----- --nextPart8569853.cRMWXsi7qV--