Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751591AbdFGOuB (ORCPT ); Wed, 7 Jun 2017 10:50:01 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:36781 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751567AbdFGOsV (ORCPT ); Wed, 7 Jun 2017 10:48:21 -0400 Message-ID: <1496846893.736.41.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [PATCH 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv From: Eric Dumazet To: Haishuang Yan Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 07 Jun 2017 07:48:13 -0700 In-Reply-To: <1496844976-15282-1-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1496844976-15282-1-git-send-email-yanhaishuang@cmss.chinamobile.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 419 Lines: 13 On Wed, 2017-06-07 at 22:16 +0800, Haishuang Yan wrote: > When ip_tunnel_rcv fails, the tun_dst won't be freed, so move > skb_dst_set to begin and tun_dst would be freed by kfree_skb. > > Signed-off-by: Haishuang Yan > --- Please add the missing Fixes: tag and CC author of the patch that added this bug, so that he has a chance to comment and avoid future similar bugs. Thanks.