Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751512AbdFGQUh (ORCPT ); Wed, 7 Jun 2017 12:20:37 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:44030 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750940AbdFGQUf (ORCPT ); Wed, 7 Jun 2017 12:20:35 -0400 Date: Wed, 7 Jun 2017 12:20:13 -0400 From: Johannes Weiner To: Andrew Morton Cc: Michael Ellerman , Yury Norov , Heiko Carstens , Josef Bacik , Michal Hocko , Vladimir Davydov , Rik van Riel , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, linux-s390@vger.kernel.org Subject: Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node counters Message-ID: <20170607162013.GA25280@cmpxchg.org> References: <20170530181724.27197-1-hannes@cmpxchg.org> <20170530181724.27197-3-hannes@cmpxchg.org> <20170531091256.GA5914@osiris> <20170531113900.GB5914@osiris> <20170531171151.e4zh7ffzbl4w33gd@yury-thinkpad> <87mv9s2f8f.fsf@concordia.ellerman.id.au> <20170605183511.GA8915@cmpxchg.org> <20170605143831.dac73f489bfe2644e103d2b3@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170605143831.dac73f489bfe2644e103d2b3@linux-foundation.org> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1047 Lines: 22 On Mon, Jun 05, 2017 at 02:38:31PM -0700, Andrew Morton wrote: > On Mon, 5 Jun 2017 14:35:11 -0400 Johannes Weiner wrote: > > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -5107,6 +5107,7 @@ static void build_zonelists(pg_data_t *pgdat) > > */ > > static void setup_pageset(struct per_cpu_pageset *p, unsigned long batch); > > static DEFINE_PER_CPU(struct per_cpu_pageset, boot_pageset); > > +static DEFINE_PER_CPU(struct per_cpu_nodestat, boot_nodestats); > > static void setup_zone_pageset(struct zone *zone); > > There's a few kb there. It just sits evermore unused after boot? It's not the greatest, but it's nothing new. All the node stats we have now used to be in the zone, i.e. the then bigger boot_pageset, before we moved them to the node level. It just re-adds static boot time space for them now. Of course, if somebody has an idea on how to elegantly reuse that memory after boot, that'd be cool. But we've lived with that footprint for the longest time, so I don't think it's a showstopper.