Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751625AbdFGQzT (ORCPT ); Wed, 7 Jun 2017 12:55:19 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:34511 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751433AbdFGQzR (ORCPT ); Wed, 7 Jun 2017 12:55:17 -0400 MIME-Version: 1.0 In-Reply-To: <20170607153933.GY30622@linux-l9pv.suse> References: <20170607060527.23407-1-jlee@suse.com> <20170607101832.GW30622@linux-l9pv.suse> <20170607153933.GY30622@linux-l9pv.suse> From: Andy Shevchenko Date: Wed, 7 Jun 2017 19:55:15 +0300 Message-ID: Subject: Re: [PATCH] acpi: handle the acpi hotplug schedule error To: joeyli Cc: "Lee, Chun-Yi" , "Rafael J . Wysocki" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Len Brown Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 646 Lines: 19 On Wed, Jun 7, 2017 at 6:39 PM, joeyli wrote: > On Wed, Jun 07, 2017 at 01:46:37PM +0300, Andy Shevchenko wrote: >> On Wed, Jun 7, 2017 at 1:18 PM, joeyli wrote: >> > On Wed, Jun 07, 2017 at 11:36:55AM +0300, Andy Shevchenko wrote: >> >> On Wed, Jun 7, 2017 at 9:05 AM, Lee, Chun-Yi wrote: > I think normally it should be success. So how about: > > if (hotplug_event) { > if (ACPI_SUCCESS(acpi_hotplug_schedule(adev, type))) > return; > goto err_put_device; > } Fine by me. -- With Best Regards, Andy Shevchenko