Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751877AbdFGUFr (ORCPT ); Wed, 7 Jun 2017 16:05:47 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:41418 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751847AbdFGUFp (ORCPT ); Wed, 7 Jun 2017 16:05:45 -0400 From: Vivien Didelot To: Florian Fainelli , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn Subject: Re: [PATCH net-next 2/5] net: dsa: check VLAN capability of every switch In-Reply-To: <8d6edbe3-a80b-6cc7-b7ec-d8f1578dea27@gmail.com> References: <20170606205631.22880-1-vivien.didelot@savoirfairelinux.com> <20170606205631.22880-3-vivien.didelot@savoirfairelinux.com> <8d6edbe3-a80b-6cc7-b7ec-d8f1578dea27@gmail.com> Date: Wed, 07 Jun 2017 16:03:31 -0400 Message-ID: <87bmpza7l8.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 922 Lines: 24 Hi Florian, Florian Fainelli writes: > On 06/06/2017 01:56 PM, Vivien Didelot wrote: >> Now that the VLAN object is propagated to every switch chip of the >> switch fabric, we can easily ensure that they all support the required >> VLAN operations before modifying an entry on a single switch. >> >> To achieve that, remove the condition skipping other target switches, >> and add a bitmap of VLAN members, eventually containing the target port, >> if we are programming the switch target. > > You could add in the commit message that with this commit, there is not > actually a functional change yet because we have one (and only one) bit > set in the members bitmap. Hum there is a small functional change though: if one interconnected switch of the fabric does not support the VLAN operations, -EOPNOTSUPP is returned (even though the target switch is VLAN capable.) Thanks, Vivien