Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751557AbdFGUK7 (ORCPT ); Wed, 7 Jun 2017 16:10:59 -0400 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:60258 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751072AbdFGUK5 (ORCPT ); Wed, 7 Jun 2017 16:10:57 -0400 Date: Wed, 7 Jun 2017 23:10:51 +0300 From: Sakari Ailus To: Andy Shevchenko Cc: Rajmohan Mani , Hans de Goede , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Lee Jones , Linus Walleij , Alexandre Courbot , "Rafael J. Wysocki" , Len Brown Subject: Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver Message-ID: <20170607201050.GE1019@valkosipuli.retiisi.org.uk> References: <1496750118-5570-1-git-send-email-rajmohan.mani@intel.com> <1496750118-5570-4-git-send-email-rajmohan.mani@intel.com> <20170607121503.GA1019@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1596 Lines: 55 Hi Andy, On Wed, Jun 07, 2017 at 04:40:13PM +0300, Andy Shevchenko wrote: > On Wed, Jun 7, 2017 at 3:15 PM, Sakari Ailus wrote: > > On Tue, Jun 06, 2017 at 05:23:56PM +0300, Andy Shevchenko wrote: > >> Follow the pattern, please, I suppose > >> ti_pmic_tps68470.c > > > > This pattern is weird. "ti" in front of the file name is redundant, and in > > very few places the vendor prefix is used anyway. Especially when the chip > > has a proper name --- as this one does. > > > > I assume for the Intel PMICs it could be there for a couple of reasons which > > are > > > > 1) lack of a clearly unique chip ID and > > > > 2) the use of common frameworklet for Intel PMICs. > > > > There are also no other PMIC chips supported currently. > > > > The pmic_tps68470 naming is in line with the GPIO driver (apart from the > > dash / underscore difference). > > Since > > % git ls-files *pmic* > > returns somewhat interesting results, I would even go further and use > > tps68470.c here > > and > > s/ti_pmic/tps6840/g > > inside the file. > > Would it work for you? This is still a different driver from the tps68470 driver which is an MFD driver. For clarity, I'd keep pmic as part of the name (and I'd use tps68470_pmic_ prefix for internal symbols, too). As PMICs are typically linked to the kernel (vs. being modules), there's no issue with the module name. I would suppose few if any PMICs will be compiled as modules in general. It's not a big deal though. I'm fine either way. -- Regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk