Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751534AbdFGUXN (ORCPT ); Wed, 7 Jun 2017 16:23:13 -0400 Received: from esa3.dell-outbound.iphmx.com ([68.232.153.94]:63083 "EHLO esa3.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751405AbdFGUXL (ORCPT ); Wed, 7 Jun 2017 16:23:11 -0400 From: X-LoopCount0: from 10.170.28.40 X-IronPort-AV: E=Sophos;i="5.39,311,1493701200"; d="scan'208";a="515266793" To: CC: , , , , , , , Subject: RE: [PATCH 15/16] platform/x86: wmi-mof: New driver to expose embedded WMI MOF metadata Thread-Topic: [PATCH 15/16] platform/x86: wmi-mof: New driver to expose embedded WMI MOF metadata Thread-Index: AQHS3kk7xMJsawcrI0WF/5NgAk77dKIXKtQAgAAFrACAANB6AP//0/SQgAHYjGyAAC0fcA== Date: Wed, 7 Jun 2017 20:23:08 +0000 Message-ID: References: <8aa135f430b441eb82614b22d662d1ff@ausx13mpc120.AMER.DELL.COM> <20170606135621.GC4690@pali> <201706071939.25681@pali> In-Reply-To: <201706071939.25681@pali> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v57KNMoU012173 Content-Length: 1585 Lines: 40 > -----Original Message----- > From: Pali Rohár [mailto:pali.rohar@gmail.com] > Sent: Wednesday, June 7, 2017 12:39 PM > To: Limonciello, Mario > Cc: luto@amacapital.net; dvhart@infradead.org; platform-driver- > x86@vger.kernel.org; andriy.shevchenko@linux.intel.com; luto@kernel.org; > rjw@rjwysocki.net; linux-kernel@vger.kernel.org; linux-acpi@vger.kernel.org > Subject: Re: [PATCH 15/16] platform/x86: wmi-mof: New driver to expose > embedded WMI MOF metadata > > On Tuesday 06 June 2017 15:56:21 Pali Rohár wrote: > > On Tuesday 06 June 2017 13:46:16 Mario.Limonciello@dell.com wrote: > > > 2) On my system when you expand the arguments for "void DoBFn" the > > > source doesn't describe individual arguments like you do. Again > > > this might not matter to MOF parsing tools but wanted to let you > > > know in case it does. > > > > I know, this part is missing. Order of arguments are only in ID > > qualifier and not sorted + in/out de-duplicated. > > Implemented! Now arguments are correctly placed based on ID qualifier. I think it's still off a little though. What I'm getting back now from bmf2mof is: void DoBFn([in, Description("Fn buf"), out] BDat Data); Whereas source puts Description as the last argument: void DoBFn([in, out, Description("Fn buf")] BDat Data); > > > > source: > > > void DoBFn([in, out, Description("Fn buf")] BDat Data); > > > > > > bmf2mof: > > > void doBFn([in, Description("Fn buf"), ID(0)] BDat Data, [out, > > > Description("Fn buf"), ID(0)] BDat Data); > > -- > Pali Rohár > pali.rohar@gmail.com