Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752025AbdFGUvM (ORCPT ); Wed, 7 Jun 2017 16:51:12 -0400 Received: from gateway20.websitewelcome.com ([192.185.58.11]:47947 "EHLO gateway20.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751826AbdFGUvI (ORCPT ); Wed, 7 Jun 2017 16:51:08 -0400 X-Greylist: delayed 1395 seconds by postgrey-1.27 at vger.kernel.org; Wed, 07 Jun 2017 16:51:08 EDT Date: Wed, 07 Jun 2017 15:27:47 -0500 Message-ID: <20170607152747.Horde.8JNiGUjUVmaDvwXKaBUwN0t@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Adaptec OEM Raid Solutions , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] scsi: remove useless variable assignment User-Agent: Horde Application Framework 5 Content-Type: multipart/mixed; boundary="=_cGxQJIzBomwWQpu0miXoyFf" MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1dIhYS-0004X8-4B X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:47691 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3345 Lines: 103 This message is in MIME format. --=_cGxQJIzBomwWQpu0miXoyFf Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Remove both variable assignments once the value stored in variable _reqlen_ is overwritten at some point either by line 2321: reqlen = mptr - msg; or by line 2330: reqlen = 12; Addresses-Coverity-ID: 1226930 Addresses-Coverity-ID: 1226931 Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/dpt_i2o.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c index 256dd67..acad668 100644 --- a/drivers/scsi/dpt_i2o.c +++ b/drivers/scsi/dpt_i2o.c @@ -2292,11 +2292,8 @@ static s32 adpt_scsi_to_i2o(adpt_hba* pHba, struct scsi_cmnd* cmd, struct adpt_d mptr+=4; lenptr=mptr++; /* Remember me - fill in when we know */ if (dpt_dma64(pHba)) { - reqlen = 16; // SINGLE SGE *mptr++ = (0x7C<<24)+(2<<16)+0x02; /* Enable 64 bit */ *mptr++ = 1 << PAGE_SHIFT; - } else { - reqlen = 14; // SINGLE SGE } /* Now fill in the SGList and command */ -- 2.5.0 --=_cGxQJIzBomwWQpu0miXoyFf Content-Type: message/rfc822; name="Forwarded Message" Return-Path: Delivered-To: garsilva@embeddedor.com Received: from gator4166.hostgator.com by gator4166.hostgator.com (Dovecot) with LMTP id oWH4BTHyHFnxgAAAA8MJhg for ; Wed, 17 May 2017 20:00:33 -0500 Return-path: Envelope-to: garsilva@embeddedor.com Delivery-date: Wed, 17 May 2017 20:00:33 -0500 Received: from [189.152.179.187] (port=60472 helo=embeddedgus) by gator4166.hostgator.com with esmtpa (Exim 4.87) (envelope-from ) id 1dB9ns-0008tH-T9; Wed, 17 May 2017 20:00:32 -0500 Date: Wed, 17 May 2017 20:00:32 -0500 From: "Gustavo A. R. Silva" To: Adaptec OEM Raid Solutions , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] scsi: remove useless variable assignment Message-ID: <20170518010032.GA12354@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Remove both variable assignments once the value stored in variable _reqlen_ is overwritten at some point either by line 2321: reqlen = mptr - msg; or by line 2330: reqlen = 12; Addresses-Coverity-ID: 1226930 Addresses-Coverity-ID: 1226931 Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/dpt_i2o.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c index 256dd67..acad668 100644 --- a/drivers/scsi/dpt_i2o.c +++ b/drivers/scsi/dpt_i2o.c @@ -2292,11 +2292,8 @@ static s32 adpt_scsi_to_i2o(adpt_hba* pHba, struct scsi_cmnd* cmd, struct adpt_d mptr+=4; lenptr=mptr++; /* Remember me - fill in when we know */ if (dpt_dma64(pHba)) { - reqlen = 16; // SINGLE SGE *mptr++ = (0x7C<<24)+(2<<16)+0x02; /* Enable 64 bit */ *mptr++ = 1 << PAGE_SHIFT; - } else { - reqlen = 14; // SINGLE SGE } /* Now fill in the SGList and command */ -- 2.5.0 --=_cGxQJIzBomwWQpu0miXoyFf--