Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751839AbdFGUvm (ORCPT ); Wed, 7 Jun 2017 16:51:42 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:33835 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751585AbdFGUvk (ORCPT ); Wed, 7 Jun 2017 16:51:40 -0400 Date: Wed, 7 Jun 2017 13:51:25 -0700 From: Guenter Roeck To: Arvind Yadav Cc: wim@iguana.be, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] watchdog: davinci: Add missing clk_disable_unprepare(). Message-ID: <20170607205125.GB29222@roeck-us.net> References: <616d54e4ee92f443b52efcd50606baa06e41760e.1496745446.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <616d54e4ee92f443b52efcd50606baa06e41760e.1496745446.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1167 Lines: 37 On Tue, Jun 06, 2017 at 04:08:31PM +0530, Arvind Yadav wrote: > davinci_wdt_probe() can fail here and we must disable clock. > > Signed-off-by: Arvind Yadav Reviewed-by: Guenter Roeck ... though I would really prefer to have devm_clk_prepare_enable() instead :-(. > --- > drivers/watchdog/davinci_wdt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/watchdog/davinci_wdt.c b/drivers/watchdog/davinci_wdt.c > index 1ba9ead..2f46487 100644 > --- a/drivers/watchdog/davinci_wdt.c > +++ b/drivers/watchdog/davinci_wdt.c > @@ -202,8 +202,10 @@ static int davinci_wdt_probe(struct platform_device *pdev) > return PTR_ERR(davinci_wdt->base); > > ret = watchdog_register_device(wdd); > - if (ret < 0) > + if (ret < 0) { > + clk_disable_unprepare(davinci_wdt->clk); > dev_err(dev, "cannot register watchdog device\n"); > + } > > return ret; > } > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html