Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751873AbdFGUxC (ORCPT ); Wed, 7 Jun 2017 16:53:02 -0400 Received: from mx08-00252a01.pphosted.com ([91.207.212.211]:56071 "EHLO mx08-00252a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751600AbdFGUxA (ORCPT ); Wed, 7 Jun 2017 16:53:00 -0400 Subject: Re: [PATCH 0/2] Add bcm2835aux interrupt controller To: Stefan Wahren References: <6dc301c8-e5a2-1334-c476-1ce7e303787f@raspberrypi.org> <1357388068.219504.1496867858076@email.1und1.de> Cc: alexanders83@web.de, linux-clk@vger.kernel.org, Stephen Boyd , Rob Herring , linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Eric Anholt , Florian Fainelli , Mark Rutland , devicetree@vger.kernel.org From: Phil Elwell Message-ID: <89e725de-c77d-6a24-3ae5-9acb061cd6bb@raspberrypi.org> Date: Wed, 7 Jun 2017 21:55:27 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1357388068.219504.1496867858076@email.1und1.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-07_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706070374 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1063 Lines: 29 On 07/06/2017 21:37, Stefan Wahren wrote: > Hi Phil, > >> Phil Elwell hat am 7. Juni 2017 um 13:11 geschrieben: >> >> >> Devices in the AUX block share a common interrupt line, with a register >> indicating which devices have active IRQs. Expose this as a nested >> interrupt controller to avoid IRQ sharing problems (easily observed if >> UART1 and SPI1/2 are enabled simultaneously). >> >> The interrupt functionality could arguably be forked off as a separate >> irqchip driver, but the clock driver has already claimed the AUX_IRQ >> register so some driver and DT surgery would still be required. >> Eric Anholt thought that including it here is reasonable, but I'm >> prepared to split it out if this is considered too hacky. > > in order to give the maintainers (e.g. irqchip) a chance, they should be included into CC. Will do. >> Phil Elwell (2): >> clk: bcm2835: Add AUX interrupt controller > > Either way the dt-binding must be updated as a separate patch. So Rob can review it. Thanks, Stefan - I'll add that to v2. Phil