Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751978AbdFGUxe (ORCPT ); Wed, 7 Jun 2017 16:53:34 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:35621 "EHLO mail-it0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638AbdFGUxc (ORCPT ); Wed, 7 Jun 2017 16:53:32 -0400 MIME-Version: 1.0 In-Reply-To: <20170607161854.GC4389@bart.dudau.co.uk> References: <1496259810-3602-1-git-send-email-jon.mason@broadcom.com> <20170602.142251.851089443438560012.davem@davemloft.net> <20170607161854.GC4389@bart.dudau.co.uk> From: Jon Mason Date: Wed, 7 Jun 2017 16:53:30 -0400 Message-ID: Subject: Re: [PATCH net-next] net: phy: use of_mdio_parse_addr To: Liviu Dudau Cc: David Miller , Andrew Lunn , Florian Fainelli , Network Development , open list , BCM Kernel Feedback Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1365 Lines: 38 On Wed, Jun 7, 2017 at 12:18 PM, Liviu Dudau wrote: > On Fri, Jun 02, 2017 at 02:22:51PM -0400, David Miller wrote: >> From: Jon Mason >> Date: Wed, 31 May 2017 15:43:30 -0400 >> >> > use of_mdio_parse_addr() in place of an OF read of reg and a bounds >> > check (which is litterally the exact same thing that >> > of_mdio_parse_addr() does) >> > >> > Signed-off-by: Jon Mason >> >> Applied, thanks Jon. > > This makes linux-next fail the modules_install target as depmod detects 2 circular > dependencies. Reverting this patch fixes the issue. > > depmod: ERROR: Cycle detected: libphy -> of_mdio -> fixed_phy -> libphy > depmod: ERROR: Cycle detected: libphy -> of_mdio -> libphy > depmod: ERROR: Found 3 modules in dependency cycles! > make[1]: *** [/home/dliviu/devel/kernel/Makefile:1245: _modinst_post] Error 1 I did not test this as modules. Sorry. It would be ugly to duplicate the code in both place, and the code in question does not seem to really need to be in a C file. Perhaps it can be moved to a header file as an inline function, which would solve this dependency. Would this be acceptable? Thanks, Jon > > This is on an ARCH=arm build, build I doubt it makes a difference. Let me know if > you need some .config values in order to reproduce. > > Best regards, > Liviu >