Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751886AbdFGUyW (ORCPT ); Wed, 7 Jun 2017 16:54:22 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:36067 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751624AbdFGUyU (ORCPT ); Wed, 7 Jun 2017 16:54:20 -0400 Subject: Re: [PATCH net-next] net: phy: use of_mdio_parse_addr To: Jon Mason , Liviu Dudau Cc: David Miller , Andrew Lunn , Florian Fainelli , Network Development , open list , BCM Kernel Feedback References: <1496259810-3602-1-git-send-email-jon.mason@broadcom.com> <20170602.142251.851089443438560012.davem@davemloft.net> <20170607161854.GC4389@bart.dudau.co.uk> From: Florian Fainelli Message-ID: <09fe3523-ab79-c854-c00f-41fe4c55064b@gmail.com> Date: Wed, 7 Jun 2017 13:54:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1323 Lines: 32 On 06/07/2017 01:53 PM, Jon Mason wrote: > On Wed, Jun 7, 2017 at 12:18 PM, Liviu Dudau wrote: >> On Fri, Jun 02, 2017 at 02:22:51PM -0400, David Miller wrote: >>> From: Jon Mason >>> Date: Wed, 31 May 2017 15:43:30 -0400 >>> >>>> use of_mdio_parse_addr() in place of an OF read of reg and a bounds >>>> check (which is litterally the exact same thing that >>>> of_mdio_parse_addr() does) >>>> >>>> Signed-off-by: Jon Mason >>> >>> Applied, thanks Jon. >> >> This makes linux-next fail the modules_install target as depmod detects 2 circular >> dependencies. Reverting this patch fixes the issue. >> >> depmod: ERROR: Cycle detected: libphy -> of_mdio -> fixed_phy -> libphy >> depmod: ERROR: Cycle detected: libphy -> of_mdio -> libphy >> depmod: ERROR: Found 3 modules in dependency cycles! >> make[1]: *** [/home/dliviu/devel/kernel/Makefile:1245: _modinst_post] Error 1 > > I did not test this as modules. Sorry. > > It would be ugly to duplicate the code in both place, and the code in > question does not seem to really need to be in a C file. Perhaps it > can be moved to a header file as an inline function, which would solve > this dependency. Would this be acceptable? You read my mind, was just going to suggest doing that. -- Florian