Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751934AbdFGVLk (ORCPT ); Wed, 7 Jun 2017 17:11:40 -0400 Received: from gate.crashing.org ([63.228.1.57]:49554 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751437AbdFGVLi (ORCPT ); Wed, 7 Jun 2017 17:11:38 -0400 Message-ID: <1496869827.2034.19.camel@kernel.crashing.org> Subject: Re: [PATCH 03/17] base: fix order of OF initialization From: Benjamin Herrenschmidt To: Wesley Terpstra , Mark Rutland Cc: Geert Uytterhoeven , Palmer Dabbelt , Linux-Arch , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Olof Johansson , Albert Ou , patches@groups.riscv.org, Rob Herring , Frank Rowand , "devicetree@vger.kernel.org" Date: Thu, 08 Jun 2017 07:10:27 +1000 In-Reply-To: References: <20170523004107.536-1-palmer@dabbelt.com> <20170606230007.19101-1-palmer@dabbelt.com> <20170606230007.19101-4-palmer@dabbelt.com> <20170607093523.GB29370@leverpostej> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2829 Lines: 76 On Wed, 2017-06-07 at 11:39 -0700, Wesley Terpstra wrote: > It was a while ago that I debugged this. I already reported this bug > to Benjamin Herrenschmidt (now in CC), and I believe he has a patch of > his own to fix the same issue. > > As I understand it, of_core_init sets up the OF entries in > /sys/firmware/devicetree. During platform bringup, when the system > describes the cpu + cache hierarchy, it also makes an of_node symlink > into that directory. However, if it doesn't exist yet, you get the > warning. Ugh... yes I did a patch for that and I think it fell through the cracks, I can't even find it anymore... The patch quoted here is fine I think. Everything in the device model can potentially use OF bits these days, it makes sense to have them initialized earlier. Cheers, Ben. > # ls -l /sys/devices/system/cpu/cpu3/of_node > lrwxrwxrwx 1 root root 0 Jan 1 00:00 > /sys/devices/system/cpu/cpu3/of_node -> > ../../../../firmware/devicetree/base/cpus/cpu@3 > > On Wed, Jun 7, 2017 at 2:35 AM, Mark Rutland wrote: > > On Wed, Jun 07, 2017 at 09:07:20AM +0200, Geert Uytterhoeven wrote: > > > CC devicetree folks > > > > > > On Wed, Jun 7, 2017 at 12:59 AM, Palmer Dabbelt wrote: > > > > From: "Wesley W. Terpstra" > > > > > > > > This fixes: [ 0.010000] cpu cpu0: Error -2 creating of_node link > > > > ... which you get for every CPU on all architectures with a OF cpu/ node. > > > > I take it this means a /cpus node? Or the /cpus/cpu@* nodes? > > > > I'm not seeing this on arm64 when booting v4.12-rc4 with DT, so clearly > > this doesn't affect all such architectures. > > > > What path are these errors happening in? > > > > Thanks, > > Mark. > > > > > > > > > > This affects riscv, nios, etc. > > > > > > > > Signed-off-by: Palmer Dabbelt > > > > --- > > > > drivers/base/init.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/base/init.c b/drivers/base/init.c > > > > index 48c0e220acc0..0dcd17e561d0 100644 > > > > --- a/drivers/base/init.c > > > > +++ b/drivers/base/init.c > > > > @@ -31,9 +31,9 @@ void __init driver_init(void) > > > > /* These are also core pieces, but must come after the > > > > * core core pieces. > > > > */ > > > > + of_core_init(); > > > > platform_bus_init(); > > > > cpu_dev_init(); > > > > memory_dev_init(); > > > > container_dev_init(); > > > > - of_core_init(); > > > > } > > > > -- > > > > 2.13.0 > > > > > > -- > > > To unsubscribe from this list: send the line "unsubscribe devicetree" in > > > the body of a message to majordomo@vger.kernel.org > > > More majordomo info at http://vger.kernel.org/majordomo-info.html