Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751641AbdFGWmJ (ORCPT ); Wed, 7 Jun 2017 18:42:09 -0400 Received: from mail-by2nam03on0070.outbound.protection.outlook.com ([104.47.42.70]:61601 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751422AbdFGWmH (ORCPT ); Wed, 7 Jun 2017 18:42:07 -0400 From: "Madhani, Himanshu" To: Colin King CC: Dept-Eng QLA2xxx Upstream , "James E . J . Bottomley" , "Martin K . Petersen" , "linux-scsi@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH][scsi-next] scsi: qla2xxx: remove redundant null check on tgt Thread-Topic: [PATCH][scsi-next] scsi: qla2xxx: remove redundant null check on tgt Thread-Index: AQHS3iFdKe9vvn4g/UKiW6IMKta456IaAkuA Date: Wed, 7 Jun 2017 22:42:03 +0000 Message-ID: References: <20170605172958.12844-1-colin.king@canonical.com> In-Reply-To: <20170605172958.12844-1-colin.king@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: canonical.com; dkim=none (message not signed) header.d=none;canonical.com; dmarc=none action=none header.from=cavium.com; x-originating-ip: [173.186.134.106] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN6PR07MB3441;7:c+CK7goh8r8f6aA8ILAWAjjgL0hdfiLxhBB99sknL/Nge0rUY4r91B+GZpWb2Ekq/0NnmZg47RvWjxNEl3FOtr8lbkb7XN8hFkk+XkBd+hRh9A2aIvKta+sg/vlDycUd1vXbsZTKi6q21OJ6ZqPbeUv7LgvNCXxkSErWQohKhaScbh4NHiVZ8e4ToEJYAUfaRu5dOFsPZ4VQda2xddcLeIiH2LcmFOyNa3YHJblbaPt3G4QSrd1B+b3qvmkHW4SjbtsF6sZ0SbQ0KNTuj5rWIXxOqyZg2xd4tl0sBXlIXPdC6mpeEJ3HkVSX9GnPxNa9A5VMMLhu77uyikBqVmDXQw== x-ms-traffictypediagnostic: BN6PR07MB3441: x-ms-office365-filtering-correlation-id: 7e1ce4e1-5cf1-41e1-9083-08d4adf66af4 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075);SRVR:BN6PR07MB3441; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(198206253151910); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR07MB3441;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR07MB3441; x-forefront-prvs: 03319F6FEF x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39410400002)(39400400002)(39850400002)(39840400002)(39450400003)(24454002)(377454003)(6246003)(66066001)(6436002)(14454004)(7736002)(25786009)(6486002)(77096006)(4326008)(6512007)(6506006)(189998001)(82746002)(72206003)(110136004)(36756003)(38730400002)(122556002)(8676002)(3660700001)(81166006)(2900100001)(6916009)(83716003)(229853002)(478600001)(33656002)(2906002)(3280700002)(54906002)(54356999)(3846002)(6116002)(53936002)(305945005)(99286003)(102836003)(8936002)(5660300001)(2950100002)(76176999)(86362001)(50986999);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR07MB3441;H:BN6PR07MB3444.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <75B6FCE620540E4892012EEAE4AB9C81@namprd07.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2017 22:42:03.1242 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3441 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v57MgECj000539 Content-Length: 1373 Lines: 46 > On Jun 5, 2017, at 10:29 AM, Colin King wrote: > > From: Colin Ian King > > An earlier commit ed7fb808477b846bb2 ("scsi: qla2xxx: Remove > redundant wait when target is stopped.") removed a null check > on ha->tgt.tgt_ops and replaced it with a new check that null > checked tgt, thus making the subsequent null check on tgt > totally redundant. Remove it. > > Detected by CoverityScan, CID#1440452 ("Logically Dead Code") > > Signed-off-by: Colin Ian King > --- > drivers/scsi/qla2xxx/qla_target.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c > index cb33ca87ca37..3594a76f6155 100644 > --- a/drivers/scsi/qla2xxx/qla_target.c > +++ b/drivers/scsi/qla2xxx/qla_target.c > @@ -5519,12 +5519,6 @@ void qlt_async_event(uint16_t code, struct scsi_qla_host *vha, > if (!tgt || tgt->tgt_stop || tgt->tgt_stopped) > return; > > - if (unlikely(tgt == NULL)) { > - ql_dbg(ql_dbg_tgt, vha, 0xe03a, > - "ASYNC EVENT %#x, but no tgt (ha %p)\n", code, ha); > - return; > - } > - > if (((code == MBA_POINT_TO_POINT) || (code == MBA_CHG_IN_CONNECTION)) && > IS_QLA2100(ha)) > return; > -- > 2.11.0 > Looks good. Acked-by: Himanshu Madhani Thanks, - Himanshu