Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752538AbdFHAKR (ORCPT ); Wed, 7 Jun 2017 20:10:17 -0400 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:18385 "EHLO cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752172AbdFHAKN (ORCPT ); Wed, 7 Jun 2017 20:10:13 -0400 X-RM-TRANSID: 2ee8593895e16c4-77baa X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee5593895e06d2-8a235 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv From: =?utf-8?B?5Lil5rW35Y+M?= In-Reply-To: <1496846893.736.41.camel@edumazet-glaptop3.roam.corp.google.com> Date: Thu, 8 Jun 2017 08:10:07 +0800 Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: References: <1496844976-15282-1-git-send-email-yanhaishuang@cmss.chinamobile.com> <1496846893.736.41.camel@edumazet-glaptop3.roam.corp.google.com> To: Eric Dumazet X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 582 Lines: 22 > On 7 Jun 2017, at 10:48 PM, Eric Dumazet wrote: > > On Wed, 2017-06-07 at 22:16 +0800, Haishuang Yan wrote: >> When ip_tunnel_rcv fails, the tun_dst won't be freed, so move >> skb_dst_set to begin and tun_dst would be freed by kfree_skb. >> >> Signed-off-by: Haishuang Yan >> --- > > Please add the missing Fixes: tag and CC author of the patch that added > this bug, so that he has a chance to comment and avoid future similar > bugs. > > Thanks. > > > Ok, I will add these information in v2 commit. Thanks.