Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751853AbdFHBql (ORCPT ); Wed, 7 Jun 2017 21:46:41 -0400 Received: from conssluserg-06.nifty.com ([210.131.2.91]:32217 "EHLO conssluserg-06.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbdFHBqj (ORCPT ); Wed, 7 Jun 2017 21:46:39 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-06.nifty.com v581kTtc029053 X-Nifty-SrcIP: [209.85.213.178] MIME-Version: 1.0 In-Reply-To: <20170607081708.ycruditlhebizzt2@flea.lan> References: <20170602223006.1653-1-sboyd@codeaurora.org> <201706031243.qNvuUbQX%fengguang.wu@intel.com> <20170605144546.b6oh5sygrza22hbe@flea.lan> <20170607081708.ycruditlhebizzt2@flea.lan> From: Masahiro Yamada Date: Thu, 8 Jun 2017 10:46:28 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] clk: sunxi-ng: Move all clock types to a library To: Maxime Ripard Cc: Arnd Bergmann , Chen-Yu Tsai , kbuild test robot , Stephen Boyd , kbuild-all@01.org, Linux Kernel Mailing List , linux-clk , Michael Turquette , Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 997 Lines: 36 2017-06-07 17:17 GMT+09:00 Maxime Ripard : > On Wed, Jun 07, 2017 at 09:36:34AM +0200, Arnd Bergmann wrote: >> On Wed, Jun 7, 2017 at 7:45 AM, Chen-Yu Tsai wrote: >> > at the bottom (with a comment) would be cleaner, and >> > we wouldn't need to modify all the existing lines. >> > AFAIK about Makefiles, that should work? >> >> Ah, yes. That's much better. >> >> Arnd > > I just applied the original patch, with that addition, and a comment > as suggested by Stephen. > Hmm, I think Kbuild expects lib.a only for the final link (at least in official level) Is it a problem to compile common files all the time? # Common objects obj-y += ccu_common.o obj-y += ccu_reset.o We may end up with some unused functions in vmlinux, but it will not be a big impact on the image size in this case. CONFIG_LD_DEAD_CODE_DATA_ELIMINATION may take care of unused symbols. I have not tested this CONFIG, though. -- Best Regards Masahiro Yamada