Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752111AbdFHCnr (ORCPT ); Wed, 7 Jun 2017 22:43:47 -0400 Received: from mail-pg0-f47.google.com ([74.125.83.47]:33532 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505AbdFHCno (ORCPT ); Wed, 7 Jun 2017 22:43:44 -0400 Date: Wed, 7 Jun 2017 19:43:36 -0700 From: Alexei Starovoitov To: Edward Cree Cc: davem@davemloft.net, Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, iovisor-dev , LKML Subject: Re: [RFC PATCH net-next 5/5] selftests/bpf: change test_verifier expectations Message-ID: <20170608024334.jgo63s2fnoi5wmia@ast-mbp> References: <92db9689-af6a-e172-ba57-195e588f9cc0@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 573 Lines: 12 On Wed, Jun 07, 2017 at 04:00:02PM +0100, Edward Cree wrote: > Some of the verifier's error messages have changed, and some constructs > that previously couldn't be verified are now accepted. > > Signed-off-by: Edward Cree > --- > tools/testing/selftests/bpf/test_verifier.c | 226 ++++++++++++++-------------- > 1 file changed, 116 insertions(+), 110 deletions(-) imo this rewrite needs more than one additional test. Like i counted at least 2 new verifier features (like negative and ptr & 0x40) All the new logic needs to be covered by tests.