Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbdFHDYU (ORCPT ); Wed, 7 Jun 2017 23:24:20 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:35416 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475AbdFHDYS (ORCPT ); Wed, 7 Jun 2017 23:24:18 -0400 MIME-Version: 1.0 In-Reply-To: <0eb529d9-a710-4305-f0e2-e2fcd5d5433a@xs4all.nl> References: <20170530094901.1807-1-hiroh@chromium.org> <1496139572.2618.19.camel@perches.com> <1496196991.2618.47.camel@perches.com> <1496203602.2618.54.camel@perches.com> <0eb529d9-a710-4305-f0e2-e2fcd5d5433a@xs4all.nl> From: Hirokazu Honda Date: Thu, 8 Jun 2017 12:24:16 +0900 Message-ID: Subject: Re: [PATCH v2] [media] vb2: core: Lower the log level of debug outputs To: Hans Verkuil Cc: Joe Perches , Pawel Osciak , Kyungmin Park , Marek Szyprowski , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1659 Lines: 46 Hi, I completely understand bitmask method now. I agree to the idea, but it is necessary to change the specification of a debug parameter. (We probably need to change a document about that?) For example, there is maybe a user who set a debug parameter 3. The user assume that logs whose levels are less than 4 are shown. However, after the bitmask method is adopted, someday the logs whose level is 1 or 2 are only shown, not 3 level logs are not shown. This will be confusing to users. The function that users can select a log method is necessary (e.g. implement dprintk_bitmask and dprintk_level) The main purpose of my patch is to not output much log messages. I think the current patch is enough to accomplish the purpose. Changing the method is a related but different task from my patch. Therefore, I think it should be done in another patch. Best, Hirokazu Honda On Wed, Jun 7, 2017 at 6:01 PM, Hans Verkuil wrote: > On 31/05/17 06:06, Joe Perches wrote: >> On Wed, 2017-05-31 at 12:28 +0900, Hirokazu Honda wrote: >>> If I understand a bitmap correctly, it is necessary to change the log level >>> for each message. >>> I didn't mean a bitmap will take a long CPU time. >>> I mean the work to change so takes a long time. >> >> No, none of the messages or levels need change, >> only the >= test changes to & so that for instance, >> level 1 and level 3 messages could be emitted >> without also emitting level 2 messages. >> >> The patch suggested is all that would be required. >> > > I prefer the solution that Joe proposed as well. > > It's more useful, esp. with a complex beast like vb2. > > Regards, > > Hans