Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752139AbdFHEnr (ORCPT ); Thu, 8 Jun 2017 00:43:47 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:35654 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752065AbdFHEnp (ORCPT ); Thu, 8 Jun 2017 00:43:45 -0400 Date: Thu, 8 Jun 2017 06:43:41 +0200 From: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= To: Andy Lutomirski Cc: Darren Hart , platform-driver-x86@vger.kernel.org, Andy Shevchenko , Andy Lutomirski , Mario Limonciello , Pali =?utf-8?B?Um9ow6Fy?= , Rafael Wysocki , "linux-kernel@vger.kernel.org" , Linux ACPI Subject: Re: [PATCH 09/16] platform/x86: wmi: Instantiate all devices before adding them Message-ID: <20170608044341.GA1171@kmp-mobile.hq.kempniu.pl> References: <20170601204339.GA1842@kmp-mobile.hq.kempniu.pl> <20170606030302.GC27270@fury> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1012 Lines: 25 > On Mon, Jun 5, 2017 at 8:03 PM, Darren Hart wrote: > > On Thu, Jun 01, 2017 at 10:43:39PM +0200, Michał Kępień wrote: > >> I know I have probably started sounding like a broken record by now, but > >> I still have not seen any response (apart from the typos getting fixed) > >> to my comments on this patch which I posted in January 2016 [1]. > >> > >> None of the issues I found back then are really critical, but I did > >> point out a potential memory leak (granted, an unlikely one), so it > >> might be a good idea to at least take a second look before merging. > >> > >> [1] https://www.spinics.net/lists/platform-driver-x86/msg08201.html > > > > Thanks for being persistent, some good points in there. I'd like to just squash > > these into this patch (9/16), but I'll include them here for an ack from you and > > Andy L. that this is what you meant, and consistent with his > > intent/understanding: > > > > Looks good to me. Same here. -- Best regards, Michał Kępień