Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751452AbdFHGWB convert rfc822-to-8bit (ORCPT ); Thu, 8 Jun 2017 02:22:01 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:38902 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725AbdFHGWA (ORCPT ); Thu, 8 Jun 2017 02:22:00 -0400 Date: Thu, 8 Jun 2017 08:21:48 +0200 From: Boris Brezillon To: Daniel Lezcano Cc: Alexandre Belloni , Nicolas Ferre , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks Message-ID: <20170608082148.78bcf1a0@bbrezillon> In-Reply-To: <20170607210848.GJ2345@mai> References: <20170530215139.9983-1-alexandre.belloni@free-electrons.com> <20170530215139.9983-47-alexandre.belloni@free-electrons.com> <20170606152104.GC2345@mai> <20170606180559.pkrr7ux2qqnmsd6y@piout.net> <20170607141735.GH2345@mai> <20170607152750.tksmyf5p3oajbsac@piout.net> <20170607210848.GJ2345@mai> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1339 Lines: 31 Le Wed, 7 Jun 2017 23:08:48 +0200, Daniel Lezcano a écrit : > On Wed, Jun 07, 2017 at 05:27:50PM +0200, Alexandre Belloni wrote: > > On 07/06/2017 at 16:17:35 +0200, Daniel Lezcano wrote: > > > > You mean you don't like how it is used? Or you don't think having the > > > > timer full name is useful? > > > > > > The field is not needed, the only place where it is used is where we affect it. > > > > > > > It is used in tcb_clksrc_register: > > > > tc.clksrc.name = tc.name; > > Yes, but tc.name is only in the scope of the function, so there is no need to > include this field in the structure, just a working buffer in the function is > enough. Hm, do you mean allocating the buffer dynamically and leaking the resource (not a real leak here, since we're talking about something that cannot be unregistered) or defining a 'static char name[]' variable in the function and passing this pointer to clksrc.name? Note that putting the name var on the stack won't work, because the core does not seem to duplicate the name, and uses clksrc->name after tcb_clksrc_register() has returned. Anyway, I'm not sure dynamically generating the name is really needed because we only accept a single tcb-clocksource device. We can just set tc.clksrc.name to "atmel-tcb-clocksource" and we should be good.