Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264151AbTFIFGt (ORCPT ); Mon, 9 Jun 2003 01:06:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264152AbTFIFGt (ORCPT ); Mon, 9 Jun 2003 01:06:49 -0400 Received: from waste.org ([209.173.204.2]:9961 "EHLO waste.org") by vger.kernel.org with ESMTP id S264151AbTFIFGs (ORCPT ); Mon, 9 Jun 2003 01:06:48 -0400 Date: Mon, 9 Jun 2003 00:20:08 -0500 From: Matt Mackall To: Matthew Dobson Cc: Trivial Patch Monkey , "Martin J. Bligh" , linux-kernel@vger.kernel.org Subject: Re: [patch] use valid value when unmapping cpus Message-ID: <20030609052008.GB31216@waste.org> References: <3EDE63FE.1010603@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3EDE63FE.1010603@us.ibm.com> User-Agent: Mutt/1.3.28i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 750 Lines: 16 On Wed, Jun 04, 2003 at 02:26:22PM -0700, Matthew Dobson wrote: > For some unknown reason, we stick a -1 in cpu_2_node when we unmap a cpu > on i386. We're better off sticking a 0 in there, because at least 0 is > a valid value if something references it. -1 is only going to cause > problems at some point down the line. Problems down the line help you find the bogus dereference. Even better to stick a poison value in there. -- Matt Mackall : http://www.selenic.com : of or relating to the moon - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/