Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751733AbdFHIAT (ORCPT ); Thu, 8 Jun 2017 04:00:19 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:32901 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751393AbdFHIAR (ORCPT ); Thu, 8 Jun 2017 04:00:17 -0400 Date: Thu, 8 Jun 2017 01:00:17 -0700 From: Christoph Hellwig To: Alex Williamson Cc: kvm@vger.kernel.org, Jesse Brandeburg , Stefan Assmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH] vfio/pci: Add Intel XXV710 to hidden INTx devices Message-ID: <20170608080017.GA12580@infradead.org> References: <20170607190132.22711.46831.stgit@gimli.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170607190132.22711.46831.stgit@gimli.home> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 500 Lines: 9 On Wed, Jun 07, 2017 at 01:01:46PM -0600, Alex Williamson wrote: > XXV710 has the same broken INTx behavior as the rest of the X/XL710 > series, the interrupt status register is not wired to report pending > INTx interrupts, thus we never associate the interrupt to the device. > Extend the device IDs to include these so that we hide that the > device supports INTx at all to the user. Is vfio really the right place for the list? Shouldn't this be keyed off the core PCI quirk for these devices?