Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751853AbdFHICQ (ORCPT ); Thu, 8 Jun 2017 04:02:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:37288 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751600AbdFHICM (ORCPT ); Thu, 8 Jun 2017 04:02:12 -0400 Subject: Re: [PATCH 3/3] libnvdimm: New ACPI 6.2 DSM functions To: Jerry Hoemann , dan.j.williams@intel.com Cc: linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org References: <1fa949387694a4b6200309d592e78f435f065f75.1496852665.git.jerry.hoemann@hpe.com> From: Johannes Thumshirn Message-ID: Date: Thu, 8 Jun 2017 10:02:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1fa949387694a4b6200309d592e78f435f065f75.1496852665.git.jerry.hoemann@hpe.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 845 Lines: 22 On 06/07/2017 07:04 PM, Jerry Hoemann wrote: > @@ -179,6 +217,10 @@ static inline const char *nvdimm_bus_cmd_name(unsigned cmd) > [ND_CMD_ARS_START] = "ars_start", > [ND_CMD_ARS_STATUS] = "ars_status", > [ND_CMD_CLEAR_ERROR] = "clear_error", > + [5] = "trans_spa", > + [7] = "ars_err_inj", > + [8] = "ars_err_inj_clr", > + [9] = "ars_err_inj_stat", > [ND_CMD_CALL] = "cmd_call", > }; Can you please add the new values to the enum in uapi/ndctl.h? I don't really like the magic numbers here. -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850