Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751864AbdFHIta (ORCPT ); Thu, 8 Jun 2017 04:49:30 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:45178 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751635AbdFHIt1 (ORCPT ); Thu, 8 Jun 2017 04:49:27 -0400 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com Date: Thu, 8 Jun 2017 09:50:35 +0100 From: Charles Keepax To: noman pouigt CC: Mark Brown , , Subject: Re: bug fix for registers debugfs file implementation [RFC] Message-ID: <20170608085035.GA28618@localhost.localdomain> References: <20170421172709.dqz7vq3vor56a5qg@sirena.org.uk> <20170424090231.GF1594@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706080159 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1652 Lines: 38 On Wed, Jun 07, 2017 at 04:31:15PM -0700, noman pouigt wrote: > On Mon, Apr 24, 2017 at 2:02 AM, Charles Keepax > wrote: > >> > I'm also very surprised that this is failing for you as I know this code > >> > has been fairly heavily exercised with devices with very large register > >> > maps much larger than 4k and my own testing is mainly doing cats which > >> > seemed to work last time I tried and should be iterating over the 4k > >> > boundary... what's the actual failure mode? I'm guessing it's > >> > >> I have integrated Florida codec(wm8281) from cirrus and it has more than 4K registers. I could not dump more than 4K with the existing interface. > >> > >> Charles, are you able to dump all the registers? > >> > > > > I seem to be able to dump all the registers just fine here (all > > 500k of them). You say it only dumps 4k worth of registers then > > just stops? What version of the kernel are you testing this > > on? The test I just ran was on Linus's tree, is this an older > > kernel or for-next? > > > > If its an older kernel are you perhaps missing one of these > > Using > https://github.com/CirrusLogic/linux-drivers/tree/v3.18-arizona/drivers > I am able to dump all the registers if I merge in that branch into my stock 3.18 setup here. My guess would be there must be some vendor kernel excitement or something going on here. If you can ping through a copy of your drivers/base/regmap/regmap-debugfs.c I can have a look at that see how it compares to mine. But I suspect you might need to work through and work out where it is bombing out in regmap_read_debugfs. Thanks, Charles