Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751948AbdFHI5t (ORCPT ); Thu, 8 Jun 2017 04:57:49 -0400 Received: from foss.arm.com ([217.140.101.70]:44312 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbdFHI5s (ORCPT ); Thu, 8 Jun 2017 04:57:48 -0400 Date: Thu, 8 Jun 2017 09:58:58 +0100 From: Lorenzo Pieralisi To: Geetha sowjanya Cc: will.deacon@arm.com, robin.murphy@arm.com, hanjun.guo@linaro.org, sudeep.holla@arm.com, iommu@lists.linux-foundation.org, robert.moore@intel.com, lv.zheng@intel.com, rjw@rjwysocki.net, jcm@redhat.com, linux-kernel@vger.kernel.org, robert.richter@cavium.com, catalin.marinas@arm.com, sgoutham@cavium.com, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, geethasowjanya.akula@gmail.com, devel@acpica.org, linu.cherian@cavium.com, Charles.Garcia-Tobin@arm.com, robh@kernel.org, Geetha Sowjanya Subject: Re: [PATCH v7 1/3] ACPI/IORT: Fixup SMMUv3 resource size for Cavium ThunderX2 SMMUv3 model Message-ID: <20170608085857.GB8607@red-moon> References: <1496145821-3411-1-git-send-email-gakula@caviumnetworks.com> <1496145821-3411-2-git-send-email-gakula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1496145821-3411-2-git-send-email-gakula@caviumnetworks.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1573 Lines: 48 On Tue, May 30, 2017 at 05:33:39PM +0530, Geetha sowjanya wrote: > From: Linu Cherian > > Cavium ThunderX2 implementation doesn't support second page in SMMU > register space. Hence, resource size is set as 64k for this model. > > Signed-off-by: Linu Cherian > Signed-off-by: Geetha Sowjanya > --- > drivers/acpi/arm64/iort.c | 10 +++++++++- > 1 files changed, 9 insertions(+), 1 deletions(-) > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index c5fecf9..bba2b59 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -833,12 +833,20 @@ static void __init arm_smmu_v3_init_resources(struct resource *res, > { > struct acpi_iort_smmu_v3 *smmu; > int num_res = 0; > + unsigned long size = SZ_128K; > > /* Retrieve SMMUv3 specific data */ > smmu = (struct acpi_iort_smmu_v3 *)node->node_data; > > + /* > + * Override the size, for Cavium ThunderX2 implementation > + * which doesn't support the page 1 SMMU register space. > + */ > + if (smmu->model == ACPI_IORT_SMMU_CAVIUM_CN99XX) > + size = SZ_64K; Nit: add a function, say arm_smmu_v3_resource_size() with the logic above that by default returns SZ_128K, I do not like this switch in the middle of this function. Lorenzo > + > res[num_res].start = smmu->base_address; > - res[num_res].end = smmu->base_address + SZ_128K - 1; > + res[num_res].end = smmu->base_address + size - 1; > res[num_res].flags = IORESOURCE_MEM; > > num_res++; > -- > 1.7.1 >