Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751538AbdFHMDe (ORCPT ); Thu, 8 Jun 2017 08:03:34 -0400 Received: from frisell.zx2c4.com ([192.95.5.64]:50407 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbdFHMDc (ORCPT ); Thu, 8 Jun 2017 08:03:32 -0400 MIME-Version: 1.0 In-Reply-To: <7B079482-B436-4FE7-A752-9518606F15AB@holtmann.org> References: <20170606174804.31124-1-Jason@zx2c4.com> <20170606174804.31124-13-Jason@zx2c4.com> <20170608030631.ywmldxzehtumeqd3@thunk.org> <7B079482-B436-4FE7-A752-9518606F15AB@holtmann.org> From: "Jason A. Donenfeld" Date: Thu, 8 Jun 2017 14:03:28 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 12/13] bluetooth/smp: ensure RNG is properly seeded before ECDH use To: Marcel Holtmann Cc: "Theodore Ts'o" , Linux Crypto Mailing List , LKML , kernel-hardening@lists.openwall.com, Greg Kroah-Hartman , "David S. Miller" , Eric Biggers , "Gustavo F. Padovan" , Johan Hedberg Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 494 Lines: 9 On Thu, Jun 8, 2017 at 7:04 AM, Marcel Holtmann wrote: >> Do we need to do all of this? Bluetooth folks, is it fair to assume >> that hci_power_on() has to be called before any bluetooth functions >> can be done? If so, adding a wait_for_random_bytes() in >> hci_power_on() might be all that is necessary. Maybe, but that could hassle bluetooth users who don't want to use any of the fancy bluetooth crypto and don't want to bother waiting for their RNG to initialize.