Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751461AbdFHMp5 (ORCPT ); Thu, 8 Jun 2017 08:45:57 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:33243 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbdFHMpy (ORCPT ); Thu, 8 Jun 2017 08:45:54 -0400 Subject: Re: [PATCH] include/linux/vfio.h: Guard powerpc-specific functions with CONFIG_VFIO_SPAPR_EEH To: Michael Ellerman , Alexey Kardashevskiy , kbuild test robot Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Alex Williamson , linuxppc-dev@lists.ozlabs.org References: <201706080005.vXjRK5G3%fengguang.wu@intel.com> <871squemf2.fsf@concordia.ellerman.id.au> From: =?UTF-8?Q?Murilo_Opsfelder_Ara=c3=bajo?= Message-ID: Date: Thu, 8 Jun 2017 09:45:47 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <871squemf2.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1264 Lines: 40 On 06/08/2017 08:41 AM, Michael Ellerman wrote: > Alexey Kardashevskiy writes: > >> Hi, >> >> How did you manage to have CONFIG_EEH=y and CONFIG_VFIO_SPAPR_EEH=n? "make >> oldconfig" fixes this to CONFIG_VFIO_SPAPR_EEH=y. > > Hmm, Murilo did you confirm the bug still happens on upstream with that > rand config? Yes, it's still happening with next-20170607. For me, `make oldconfig` hasn't changed it to CONFIG_VFIO_SPAPR_EEH=y. See: $ git clean -dfxq $ git reset --hard origin/master HEAD is now at 8d1b80c Add linux-next specific files for 20170607 $ curl http://kisskb.ellerman.id.au/kisskb/buildresult/12982362/config/ -o .config $ grep -E 'EEH|SPAPR' .config CONFIG_EEH=y # CONFIG_SPAPR_TCE_IOMMU is not set $ yes '' | make oldconfig $ grep -E 'EEH|SPAPR' .config CONFIG_EEH=y # CONFIG_SPAPR_TCE_IOMMU is not set $ make -j 160 ARCH=powerpc ... drivers/vfio/pci/vfio_pci.o: In function `.vfio_pci_release': vfio_pci.c:(.text+0xa98): undefined reference to `.vfio_spapr_pci_eeh_release' drivers/vfio/pci/vfio_pci.o: In function `.vfio_pci_open': vfio_pci.c:(.text+0x1420): undefined reference to `.vfio_spapr_pci_eeh_open' make: *** [vmlinux] Error 1 -- Murilo