Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750822AbdFHMur (ORCPT ); Thu, 8 Jun 2017 08:50:47 -0400 Received: from mail-wr0-f180.google.com ([209.85.128.180]:33927 "EHLO mail-wr0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbdFHMup (ORCPT ); Thu, 8 Jun 2017 08:50:45 -0400 Date: Thu, 8 Jun 2017 14:50:42 +0200 From: Lars Ellenberg To: Greg KH Cc: Philipp Reisner , drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drbd: rename "usermode_helper" to "drbd_usermode_helper" Message-ID: <20170608125042.GE13239@soda.linbit> Mail-Followup-To: Greg KH , Philipp Reisner , drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org References: <20170605092623.GA20170@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170605092623.GA20170@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 577 Lines: 15 On Mon, Jun 05, 2017 at 11:26:23AM +0200, Greg KH wrote: > From: Greg Kroah-Hartman > > Nothing like having a very generic global variable in a tiny driver > subsystem to make a mess of the global namespace... > > Note, there are many other "generic" named global variables in the drbd > subsystem, someone should fix those up one day before they hit a linking > error. Thanks. We'll prepare a patch to that effect, probably converting some of them to static, fixing up the rest, and submit with the updates for the next merge window. Lars