Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751576AbdFHNKS (ORCPT ); Thu, 8 Jun 2017 09:10:18 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34808 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbdFHNKQ (ORCPT ); Thu, 8 Jun 2017 09:10:16 -0400 Subject: Re: [PATCH] include/linux/vfio.h: Guard powerpc-specific functions with CONFIG_VFIO_SPAPR_EEH To: =?UTF-8?Q?Murilo_Opsfelder_Ara=c3=bajo?= , Michael Ellerman , kbuild test robot Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Alex Williamson , linuxppc-dev@lists.ozlabs.org References: <201706080005.vXjRK5G3%fengguang.wu@intel.com> <871squemf2.fsf@concordia.ellerman.id.au> From: Alexey Kardashevskiy Message-ID: Date: Thu, 8 Jun 2017 23:10:10 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Language: en-AU Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1717 Lines: 55 On 08/06/17 22:45, Murilo Opsfelder Araújo wrote: > On 06/08/2017 08:41 AM, Michael Ellerman wrote: >> Alexey Kardashevskiy writes: >> >>> Hi, >>> >>> How did you manage to have CONFIG_EEH=y and CONFIG_VFIO_SPAPR_EEH=n? "make >>> oldconfig" fixes this to CONFIG_VFIO_SPAPR_EEH=y. >> >> Hmm, Murilo did you confirm the bug still happens on upstream with that >> rand config? > > Yes, it's still happening with next-20170607. The config you attached in the first mail has CONFIG_VFIO_SPAPR_EEH=m, here is my confusion. The config from the link below does not have KVM_BOOK3S_64 which selects SPAPR_TCE_IOMMU and which in turn selects VFIO_IOMMU_SPAPR_TCE. So https://github.com/0day-ci/linux/commit/36ed1ddb05e132aa3cfbb610f0f8402a0774da12 looks correct. > > For me, `make oldconfig` hasn't changed it to CONFIG_VFIO_SPAPR_EEH=y. See: > > $ git clean -dfxq > $ git reset --hard origin/master > HEAD is now at 8d1b80c Add linux-next specific files for 20170607 > > $ curl http://kisskb.ellerman.id.au/kisskb/buildresult/12982362/config/ -o .config > $ grep -E 'EEH|SPAPR' .config > CONFIG_EEH=y > # CONFIG_SPAPR_TCE_IOMMU is not set > > $ yes '' | make oldconfig > > $ grep -E 'EEH|SPAPR' .config > CONFIG_EEH=y > # CONFIG_SPAPR_TCE_IOMMU is not set > > $ make -j 160 ARCH=powerpc > ... > drivers/vfio/pci/vfio_pci.o: In function `.vfio_pci_release': > vfio_pci.c:(.text+0xa98): undefined reference to `.vfio_spapr_pci_eeh_release' > drivers/vfio/pci/vfio_pci.o: In function `.vfio_pci_open': > vfio_pci.c:(.text+0x1420): undefined reference to `.vfio_spapr_pci_eeh_open' > make: *** [vmlinux] Error 1 > -- Alexey