Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751534AbdFHNOr (ORCPT ); Thu, 8 Jun 2017 09:14:47 -0400 Received: from mga14.intel.com ([192.55.52.115]:41762 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132AbdFHNOq (ORCPT ); Thu, 8 Jun 2017 09:14:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,315,1493708400"; d="scan'208";a="978329870" Subject: Re: [PATCH] IB/qib: remove duplicate code To: "Gustavo A. R. Silva" , Mike Marciniszyn , Doug Ledford , Sean Hefty , Hal Rosenstock Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170607204202.GA29640@embeddedgus> From: Dennis Dalessandro Message-ID: Date: Thu, 8 Jun 2017 09:14:44 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170607204202.GA29640@embeddedgus> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 986 Lines: 30 On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote: > Remove duplicate code. > > Addresses-Coverity-ID: 1226951 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/infiniband/hw/qib/qib_mad.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c > index da295e0..c5eaa3c 100644 > --- a/drivers/infiniband/hw/qib/qib_mad.c > +++ b/drivers/infiniband/hw/qib/qib_mad.c > @@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp *smp, struct ib_device *ibdev, > ib_dispatch_event(&event); > } > > - ret = subn_get_portinfo(smp, ibdev, port); > - > /* restore re-reg bit per o14-12.2.1 */ > pip->clientrereg_resv_subnetto |= clientrereg; > > Would be nice to see a few more words in the commit message rather than having to go look for Coverity. Regardless, patch seems fine to me code wise. Reviewed-by: Dennis Dalessandro