Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbdFHNgr (ORCPT ); Thu, 8 Jun 2017 09:36:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:46496 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751679AbdFHNgn (ORCPT ); Thu, 8 Jun 2017 09:36:43 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 098FE22CB4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Thu, 8 Jun 2017 09:36:34 -0400 From: Steven Rostedt To: Juri Lelli Cc: Luca Abeni , Ingo Molnar , linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Claudio Scordino , Tommaso Cucinotta , Daniel Bristot de Oliveira , Joel Fernandes , Mathieu Poirier , Luca Abeni Subject: Re: [PATCH 01/10] sched/deadline: track the active utilization Message-ID: <20170608093634.530fcfa7@gandalf.local.home> In-Reply-To: <20170608090555.hn4v32vamazl5ufa@e106622-lin> References: <1495138417-6203-1-git-send-email-luca.abeni@santannapisa.it> <1495138417-6203-2-git-send-email-luca.abeni@santannapisa.it> <20170608083125.6cum2zoklnzi2mbx@gmail.com> <20170608104322.060b9139@luca> <20170608090555.hn4v32vamazl5ufa@e106622-lin> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2340 Lines: 57 On Thu, 8 Jun 2017 10:05:55 +0100 Juri Lelli wrote: > On 08/06/17 10:43, Luca Abeni wrote: > > On Thu, 8 Jun 2017 10:31:25 +0200 > > Ingo Molnar wrote: > > > > > * luca abeni wrote: > > > > > > > From: Luca Abeni > > > > > > > > Active utilization is defined as the total utilization of active > > > > (TASK_RUNNING) tasks queued on a runqueue. Hence, it is increased > > > > when a task wakes up and is decreased when a task blocks. > > > > > > > > When a task is migrated from CPUi to CPUj, immediately subtract the > > > > task's utilization from CPUi and add it to CPUj. This mechanism is > > > > implemented by modifying the pull and push functions. > > > > Note: this is not fully correct from the theoretical point of view > > > > (the utilization should be removed from CPUi only at the 0 lag > > > > time), a more theoretically sound solution is presented in the > > > > next patches. > > > > > > > > Signed-off-by: Juri Lelli > > > > Signed-off-by: Luca Abeni > > > > Tested-by: Daniel Bristot de Oliveira > > > > > > So that SOB chain is not valid - either Juri needs to be the From: > > > author, or it should be an Acked-by (or Reviewed-by). > > > > > > For now I've converted this to: > > > > > > > Signed-off-by: Luca Abeni > > > > Acked-by: Juri Lelli > > > > Sorry, my fault: I must have misunderstood how to use the Signed-off-by > > stuff. > > > > The story here is that I took a patch originally developed by Juri and > > fixed and I heavily modified it. Since the current patch is very > > different from the original one, Juri suggested I should by the "From:" > > author, and I simply added his Signed-off-by to acknowledge that he was > > the author of the original patch. > > > > If Juri is ok with your change, I agree with it. > > > > Yep, I'm OK with Ingo's solution. > Although, since the code originally came from you a Signed-off-by is appropriate. The SOB is a chain of where the patch came from. As Juri actually has part ownership, Juri should have a signed-off-by on the patch. The problem with git is that it allows for multiple signed off bys but only one owner. -- Steve