Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752196AbdFHN6S (ORCPT ); Thu, 8 Jun 2017 09:58:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:44977 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751778AbdFHN6Q (ORCPT ); Thu, 8 Jun 2017 09:58:16 -0400 Subject: Re: [PATCH] pinctrl: meson-gxl: add tsin_a pins To: Jerome Brunet Cc: Linus Walleij , Kevin Hilman , Carlo Caione , linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20170608130948.16426-1-jbrunet@baylibre.com> <1496930016.3552.45.camel@baylibre.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <07b2ff66-6ac1-5e20-b70f-4dec2e050337@suse.de> Date: Thu, 8 Jun 2017 15:58:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1496930016.3552.45.camel@baylibre.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1089 Lines: 30 Am 08.06.2017 um 15:53 schrieb Jerome Brunet: > On Thu, 2017-06-08 at 15:49 +0200, Andreas Färber wrote: >> Am 08.06.2017 um 15:09 schrieb Jerome Brunet: >>> Add Tsin A pins to bank DV and X. >>> We don't have a driver for the tsin yet but since the tsin A pinmux is >>> enabled by default at boot time, declaring this pinmux is required to >>> properly operate on GPIOX. >>> >>> Without this change, GPIOX 8, 9, 10 and 11 can't be driven as GPIO output >>> as the tsin A seems to have priority. >> >> Should this get a Fixes header then for stable backports? > > Nothing is wrong with what is already in. This is merely an addition. Your above description of not being able to use GPIOs on e.g. the GXL based Khadas Vim devboard sounded like a bug to me. > If we go that way, all commit to this file should have a Fixes to the > initial commit. This seems a bit extreme to me ... Thought it might have been just an oversight. Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)