Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264082AbTFILvH (ORCPT ); Mon, 9 Jun 2003 07:51:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264124AbTFILvH (ORCPT ); Mon, 9 Jun 2003 07:51:07 -0400 Received: from phoenix.infradead.org ([195.224.96.167]:29450 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S264082AbTFILvB (ORCPT ); Mon, 9 Jun 2003 07:51:01 -0400 Date: Mon, 9 Jun 2003 13:04:38 +0100 From: Christoph Hellwig To: Jaroslav Kysela Cc: LKML , ALSA development , kbuild-devel@lists.sourceforge.net Subject: Re: 2.5 kbuild: use of '-z muldefs' for LD? Message-ID: <20030609130438.A6417@infradead.org> Mail-Followup-To: Christoph Hellwig , Jaroslav Kysela , LKML , ALSA development , kbuild-devel@lists.sourceforge.net References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from perex@suse.cz on Mon, Jun 09, 2003 at 01:56:59PM +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1374 Lines: 37 On Mon, Jun 09, 2003 at 01:56:59PM +0200, Jaroslav Kysela wrote: > one object file for more targets. Example: > > ------ > snd-ice1712-objs := ice1712.o delta.o hoontech.o ews.o ak4xxx.o > snd-ice1724-objs := ice1724.o amp.o revo.o aureon.o ak4xxx.o > > # Toplevel Module Dependency > obj-$(CONFIG_SND_ICE1712) += snd-ice1712.o > obj-$(CONFIG_SND_ICE1724) += snd-ice1724.o > ------ > > The ak4xxx.o module is shared and has defined a few public functions. > Unfortunately, the default build-in.o rule fails when targets are > requested to be included into the solid kernel because the public > functions are duplicated in snd-ice1712.o and snd-ice17124.o. > > I can instruct the ld compiler to ignore the multiple definitions using > '-z muldefs': > > EXTRA_LDFLAGS = -z muldefs > > But it seems like a hack for me. > Does anybody have another idea to solve my problem? Move ak4xxx.o out of the multi-obj rules. Just declare a new helper- config option CONFIG_SND_AK4XXX that gets defined by all drivers using it and add obj-$(CONFIG_SND_AK4XXX) += ak4xxx.o You'll just have to make sure to export all symbols in 2.5 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/