Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751906AbdFHOFa (ORCPT ); Thu, 8 Jun 2017 10:05:30 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:37361 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751591AbdFHOF2 (ORCPT ); Thu, 8 Jun 2017 10:05:28 -0400 Message-ID: <1496930716.3552.47.camel@baylibre.com> Subject: Re: [PATCH] pinctrl: meson-gxl: add tsin_a pins From: Jerome Brunet To: Andreas =?ISO-8859-1?Q?F=E4rber?= Cc: Linus Walleij , Kevin Hilman , Carlo Caione , linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Date: Thu, 08 Jun 2017 16:05:16 +0200 In-Reply-To: <07b2ff66-6ac1-5e20-b70f-4dec2e050337@suse.de> References: <20170608130948.16426-1-jbrunet@baylibre.com> <1496930016.3552.45.camel@baylibre.com> <07b2ff66-6ac1-5e20-b70f-4dec2e050337@suse.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1218 Lines: 32 On Thu, 2017-06-08 at 15:58 +0200, Andreas Färber wrote: > Am 08.06.2017 um 15:53 schrieb Jerome Brunet: > > On Thu, 2017-06-08 at 15:49 +0200, Andreas Färber wrote: > > > Am 08.06.2017 um 15:09 schrieb Jerome Brunet: > > > > Add Tsin A pins to bank DV and X. > > > > We don't have a driver for the tsin yet but since the tsin A pinmux is > > > > enabled by default at boot time, declaring this pinmux is required to > > > > properly operate on GPIOX. > > > > > > > > Without this change, GPIOX 8, 9, 10 and 11 can't be driven as GPIO > > > > output > > > > as the tsin A seems to have priority. > > > > > > Should this get a Fixes header then for stable backports? > > > > Nothing is wrong with what is already in. This is merely an addition. > > Your above description of not being able to use GPIOs on e.g. the GXL > based Khadas Vim devboard sounded like a bug to me. As far as I know, the affected pins (GPIOX 8 to 11) are used for BTPCM, not GPIOs, on all supported designs, including the Vim. > > > If we go that way, all commit to this file should have a Fixes to the > > initial commit. This seems a bit extreme to me ... > > Thought it might have been just an oversight. > > Cheers, > Andreas >