Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751788AbdFHOLC (ORCPT ); Thu, 8 Jun 2017 10:11:02 -0400 Received: from foss.arm.com ([217.140.101.70]:49674 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765AbdFHOK7 (ORCPT ); Thu, 8 Jun 2017 10:10:59 -0400 Date: Thu, 8 Jun 2017 15:10:53 +0100 From: Catalin Marinas To: Yury Norov Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Arnd Bergmann , Andrew Pinski , Heiko Carstens , Chris Metcalf , philipp.tomsich@theobroma-systems.com, Joseph Myers , zhouchengming1@huawei.com, Steve Ellcey , Prasun.Kapoor@caviumnetworks.com, Andreas Schwab , agraf@suse.de, szabolcs.nagy@arm.com, geert@linux-m68k.org, Adam Borowski , manuel.montezelo@gmail.com, Chris Metcalf , Andrew Pinski , linyongting@huawei.com, klimov.linux@gmail.com, broonie@kernel.org, Bamvor Zhangjian , Maxim Kuvyrkov , Florian Weimer , Nathan_Lynch@mentor.com, Ramana Radhakrishnan , schwidefsky@de.ibm.com, davem@davemloft.net, christoph.muellner@theobroma-systems.com Subject: Re: [PATCH 13/20] arm64: ilp32: share aarch32 syscall handlers Message-ID: <20170608141053.66i57zhvunrj6sei@localhost> References: <20170604120009.342-1-ynorov@caviumnetworks.com> <20170604120009.342-14-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170604120009.342-14-ynorov@caviumnetworks.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 364 Lines: 11 On Sun, Jun 04, 2017 at 03:00:02PM +0300, Yury Norov wrote: > off_t is passed in register pair just like in aarch32. > In this patch corresponding aarch32 handlers are shared to > ilp32 code. Is the comment here relevant? IOW, do we have any AArch64/ILP32 syscall where off_t is used as an argument? AFAICT, the *64 syscalls use loff_t or loff_t *. -- Catalin