Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751755AbdFHO3B (ORCPT ); Thu, 8 Jun 2017 10:29:01 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35677 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbdFHO26 (ORCPT ); Thu, 8 Jun 2017 10:28:58 -0400 MIME-Version: 1.0 In-Reply-To: <20170608141053.66i57zhvunrj6sei@localhost> References: <20170604120009.342-1-ynorov@caviumnetworks.com> <20170604120009.342-14-ynorov@caviumnetworks.com> <20170608141053.66i57zhvunrj6sei@localhost> From: Arnd Bergmann Date: Thu, 8 Jun 2017 16:28:56 +0200 X-Google-Sender-Auth: BV5JU-wEN7tOuJ2Mk4gl2ckfrYs Message-ID: Subject: Re: [PATCH 13/20] arm64: ilp32: share aarch32 syscall handlers To: Catalin Marinas Cc: Yury Norov , Linux ARM , Linux Kernel Mailing List , linux-doc@vger.kernel.org, Andrew Pinski , Heiko Carstens , Chris Metcalf , philipp.tomsich@theobroma-systems.com, Joseph Myers , zhouchengming1@huawei.com, Steve Ellcey , Prasun.Kapoor@caviumnetworks.com, Andreas Schwab , Alexander Graf , szabolcs.nagy@arm.com, Geert Uytterhoeven , Adam Borowski , manuel.montezelo@gmail.com, Chris Metcalf , Andrew Pinski , linyongting@huawei.com, klimov.linux@gmail.com, Mark Brown , Bamvor Zhangjian , Maxim Kuvyrkov , Florian Weimer , Nathan_Lynch@mentor.com, Ramana Radhakrishnan , Martin Schwidefsky , David Miller , christoph.muellner@theobroma-systems.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 591 Lines: 14 On Thu, Jun 8, 2017 at 4:10 PM, Catalin Marinas wrote: > On Sun, Jun 04, 2017 at 03:00:02PM +0300, Yury Norov wrote: >> off_t is passed in register pair just like in aarch32. >> In this patch corresponding aarch32 handlers are shared to >> ilp32 code. > > Is the comment here relevant? IOW, do we have any AArch64/ILP32 syscall > where off_t is used as an argument? AFAICT, the *64 syscalls use loff_t > or loff_t *. I think it should just be reworded, the 'off_t' above seems to refer to the user space type that corresponds to the kernel's loff_t. Arnd