Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751755AbdFHO3B (ORCPT <rfc822;w@1wt.eu>);
        Thu, 8 Jun 2017 10:29:01 -0400
Received: from mail-oi0-f66.google.com ([209.85.218.66]:35677 "EHLO
        mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751469AbdFHO26 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Jun 2017 10:28:58 -0400
MIME-Version: 1.0
In-Reply-To: <20170608141053.66i57zhvunrj6sei@localhost>
References: <20170604120009.342-1-ynorov@caviumnetworks.com>
 <20170604120009.342-14-ynorov@caviumnetworks.com> <20170608141053.66i57zhvunrj6sei@localhost>
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 8 Jun 2017 16:28:56 +0200
X-Google-Sender-Auth: BV5JU-wEN7tOuJ2Mk4gl2ckfrYs
Message-ID: <CAK8P3a1L0YAUnMdFw5WOLNPr8eQkD4umbWN+pr50ESLon9rdZg@mail.gmail.com>
Subject: Re: [PATCH 13/20] arm64: ilp32: share aarch32 syscall handlers
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Yury Norov <ynorov@caviumnetworks.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-doc@vger.kernel.org,
        Andrew Pinski <Andrew.Pinski@caviumnetworks.com>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        Chris Metcalf <cmetcalf@ezchip.com>,
        philipp.tomsich@theobroma-systems.com,
        Joseph Myers <joseph@codesourcery.com>, zhouchengming1@huawei.com,
        Steve Ellcey <sellcey@caviumnetworks.com>,
        Prasun.Kapoor@caviumnetworks.com, Andreas Schwab <schwab@suse.de>,
        Alexander Graf <agraf@suse.de>, szabolcs.nagy@arm.com,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Adam Borowski <kilobyte@angband.pl>, manuel.montezelo@gmail.com,
        Chris Metcalf <cmetcalf@mellanox.com>,
        Andrew Pinski <pinskia@gmail.com>, linyongting@huawei.com,
        klimov.linux@gmail.com, Mark Brown <broonie@kernel.org>,
        Bamvor Zhangjian <bamvor.zhangjian@huawei.com>,
        Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
        Florian Weimer <fweimer@redhat.com>, Nathan_Lynch@mentor.com,
        Ramana Radhakrishnan <ramana.gcc@googlemail.com>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        David Miller <davem@davemloft.net>,
        christoph.muellner@theobroma-systems.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 591
Lines: 14

On Thu, Jun 8, 2017 at 4:10 PM, Catalin Marinas <catalin.marinas@arm.com> wrote:
> On Sun, Jun 04, 2017 at 03:00:02PM +0300, Yury Norov wrote:
>> off_t is  passed in register pair just like in aarch32.
>> In this patch corresponding aarch32 handlers are shared to
>> ilp32 code.
>
> Is the comment here relevant? IOW, do we have any AArch64/ILP32 syscall
> where off_t is used as an argument? AFAICT, the *64 syscalls use loff_t
> or loff_t *.

I think it should just be reworded, the 'off_t' above seems to refer to the
user space type that corresponds to the kernel's loff_t.

       Arnd