Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751815AbdFHPA3 (ORCPT ); Thu, 8 Jun 2017 11:00:29 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:43961 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbdFHPA2 (ORCPT ); Thu, 8 Jun 2017 11:00:28 -0400 X-Auth-Info: 4xmrjGsH0K0WagX+CWn6BrA727PwfF8KvkNZMpQFGsw= Date: Thu, 8 Jun 2017 17:00:24 +0200 From: Anatolij Gustschin To: Andy Shevchenko Cc: linux-fpga@vger.kernel.org, Alan Tull , Moritz Fischer , "linux-kernel@vger.kernel.org" , matthew.gerlach@linux.intel.com, yi1.li@linux.intel.com Subject: Re: [PATCH v5] fpga manager: Add Altera CvP driver Message-ID: <20170608170024.3d2b69b7@crub> In-Reply-To: References: <1494777082-13375-1-git-send-email-agust@denx.de> <20170608010928.3effdf38@crub> <20170608161519.67e3908d@crub> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 950 Lines: 29 On Thu, 8 Jun 2017 17:44:19 +0300 Andy Shevchenko andy.shevchenko@gmail.com wrote: >On Thu, Jun 8, 2017 at 5:15 PM, Anatolij Gustschin wrote: >> On Thu, 8 Jun 2017 02:38:55 +0300 >> Andy Shevchenko andy.shevchenko@gmail.com wrote: >>>On Thu, Jun 8, 2017 at 2:09 AM, Anatolij Gustschin wrote: >>>> On Fri, 2 Jun 2017 20:43:21 +0300 >>>> Andy Shevchenko andy.shevchenko@gmail.com wrote: > >>>Besides below comments, please, do >>> >>>s/VSEC_/VSE_/g >>> >>>for entire file. >>> >>>We are following PCI and Thunderbolt pattern for use of Vendor >>>Specific Extended Capability. >> >> I can do it, but I'm just not getting why. The registers are named as VSEC >> registers in the documentation, why should the code name them differently? > >Does your documentation decode VSEC abbreviation? >What C stands for? Capability? the CvP user guide talks about Vendor Specific Extended Capability (VSEC). -- Anatolij