Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751956AbdFHPTS (ORCPT ); Thu, 8 Jun 2017 11:19:18 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:33845 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751701AbdFHPTQ (ORCPT ); Thu, 8 Jun 2017 11:19:16 -0400 MIME-Version: 1.0 In-Reply-To: <1496916298-5909-3-git-send-email-binoy.jayan@linaro.org> References: <1496916298-5909-1-git-send-email-binoy.jayan@linaro.org> <1496916298-5909-3-git-send-email-binoy.jayan@linaro.org> From: Arnd Bergmann Date: Thu, 8 Jun 2017 17:19:15 +0200 X-Google-Sender-Auth: BYGiHeynpFKKZeADyK9k6BfdwNc Message-ID: Subject: Re: [PATCH 2/3] media: ngene: Replace semaphore stream_mutex with mutex To: Binoy Jayan Cc: Linux Kernel Mailing List , Rajendra , Mark Brown , Mauro Carvalho Chehab , Sakari Ailus , Julia Lawall , "Michael S. Tsirkin" , Cao jin , Linux Media Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 477 Lines: 14 On Thu, Jun 8, 2017 at 12:04 PM, Binoy Jayan wrote: > The semaphore 'stream_mutex' is used as a simple mutex, so > it should be written as one. Semaphores are going away in the future. > > Signed-off-by: Binoy Jayan > --- Looks correct, though I wonder whether it would be nicer to move the mutex_lock/unlock() to the caller to avoid repeating the unlock() five times. Either way, Reviewed-by: Arnd Bergmann