Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751776AbdFHRio (ORCPT ); Thu, 8 Jun 2017 13:38:44 -0400 Received: from g2t2352.austin.hpe.com ([15.233.44.25]:33126 "EHLO g2t2352.austin.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751552AbdFHRil (ORCPT ); Thu, 8 Jun 2017 13:38:41 -0400 From: "Kani, Toshimitsu" To: "dan.j.williams@intel.com" , "Knippers, Linda" CC: "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" , "linux-acpi@vger.kernel.org" , "rjw@rjwysocki.net" , "vishal.l.verma@intel.com" Subject: Re: [PATCH] Add support of NVDIMM memory error notification in ACPI 6.2 Thread-Topic: [PATCH] Add support of NVDIMM memory error notification in ACPI 6.2 Thread-Index: AQHS3770gIvIG2RgykSVdl0qpZhIVKIZw7kAgAAeJICAAAKEgIAAB20AgAFOpoCAAAD8AIAAAP6A Date: Thu, 8 Jun 2017 17:38:21 +0000 Message-ID: <1496943475.9288.5.camel@hpe.com> References: <20170607184947.18733-1-toshi.kani@hpe.com> <1496869051.9288.1.camel@hpe.com> <1496871186.9288.3.camel@hpe.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [15.211.195.8] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DF4PR84MB0074;7:R3hHK8ulEaIXFtJnzp0AZd2b/xZ4jnwunxOI0eZh7lGMdn+JM+nu1By+0syRdqwxsKqSc9/x1oPzMeFMCB4Iy1eEz3EwlXiDOrEN/ADYNJVUW8ePI+wGkJ+y5J0n3xbyawXerte2m4JklvR06X/Vb8y7DXPmvD7jSA1AMmJ/yFxGV/b08PRtuGzA+VhoAN9xIq7sobRTNUkpYK+opC6WAQpzrL015MgFg0stwOtlKRhznC07pTg4BMJMvx1DQ8yphNmchwATpY5i6qzsvto0aKbOMapudzbsCvGJsBETqC2345qmq7a6/4cSppywOj/orSKVnSBir/34PwIyWGIbLw== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10019020)(6009001)(39410400002)(39400400002)(39850400002)(39860400002)(39840400002)(39450400003)(24454002)(377424004)(377454003)(76176999)(2900100001)(81166006)(54356999)(8936002)(50986999)(4326008)(6246003)(8676002)(93886004)(2950100002)(3660700001)(5660300001)(6636002)(103116003)(86362001)(2906002)(3280700002)(36756003)(2501003)(122556002)(6512007)(478600001)(53936002)(6506006)(229853002)(6436002)(3846002)(102836003)(7736002)(189998001)(25786009)(77096006)(6486002)(38730400002)(66066001)(15650500001)(53546009)(305945005)(54906002)(33646002)(14454004);DIR:OUT;SFP:1102;SCL:1;SRVR:DF4PR84MB0074;H:DF4PR84MB0105.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;MLV:sfv;LANG:en; x-ms-traffictypediagnostic: DF4PR84MB0074: x-ms-office365-filtering-correlation-id: 3587f2f2-3e85-4250-364a-08d4ae952863 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:DF4PR84MB0074; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123560025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DF4PR84MB0074;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DF4PR84MB0074; x-forefront-prvs: 0332AACBC3 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2017 17:38:21.6095 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0074 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v58Hd4GD022775 Content-Length: 1298 Lines: 31 On Thu, 2017-06-08 at 10:34 -0700, Dan Williams wrote: > On Thu, Jun 8, 2017 at 10:30 AM, Linda Knippers om> wrote: > [..] > > Wasn't Dan concerned about how the OS can know whether the FW > > supports that bit in the Start ARS? > > > > The Query ARS Capabilities DSM has a bit that tells the OS whether > > the platform supports the notification and the point of the > > notification was to tell the OS it could do a Start ARS with bit 1 > > set.  Of course, if you get the notification then that means the > > platform has the capability to deliver it, but it might not hurt to > > check the flag from the Query Capabilities bit. > > Good point, yes, I think it is safe to assume that a BIOS that claims > to support un-correctable error notification also supports this Start > ARS flag. Yes, ACPI 6.2, section 9.20.7.2, defines that:       Upon receiving the notification, the OSPM may decide to issue       a Start ARS with Flags Bit [1] set to prepare for the retrieval       of existing records and issue the Query ARS Status function to       retrieve the records. So, I believe it is safe to assume that BIOS supporting 0x81 also supports flags Big [1]. Sorry, this is what I should have said in my previous email... Thanks, -Toshi