Date: Thu, 8 Jun 2017 20:24:01 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Felix Schnizlein <fschnizlein@suse.com>
Cc: linux-kernel@vger.kernel.org, x86@vger.kernel.org,
        yanmin.zhang@intel.com, trenn@suse.com
Subject: Re: [RFC PATCH 2/3] Implement sysfs based cpuinfo for x86 cpus.
Message-ID: <20170608182401.GC13995@kroah.com>
References: <1496940975-9164-1-git-send-email-fschnizlein@suse.com>
 <1496940975-9164-3-git-send-email-fschnizlein@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1496940975-9164-3-git-send-email-fschnizlein@suse.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1108
Lines: 31

On Thu, Jun 08, 2017 at 06:56:14PM +0200, Felix Schnizlein wrote:
> A few entries have been omitted, due to already existing information in
> sysfs:
> 
> - microcode -> /sys/devices/system/cpu/cpu*/microcode/version
> - cache -> /sys/devices/system/cpu/cpu*/cache/index*/size
> - core_id -> /sys/devices/system/cpu/cpu*/topology/core_id
> - siblings -> /sys/devices/system/cpu/cpu*/topology/core_siblings_list
> - pyshical_id -> /sys/devices/system/cpu/cpu*/topology/physical_package_id
> 
> Following attributes have been removed due to obsolete information or
> legacy processors: wp, power management, f00f bug, coma bug, fdiv bug
> 
> Signed-off-by: Thomas Renninger <trenn@suse.com>

Again, no signoff from you?

> ---
>  arch/x86/kernel/Makefile        |   1 +
>  arch/x86/kernel/cpuinfo_sysfs.c | 166 ++++++++++++++++++++++++++++++++++++++++
>  drivers/base/cpuinfo.c          |   4 -
>  3 files changed, 167 insertions(+), 4 deletions(-)
>  create mode 100644 arch/x86/kernel/cpuinfo_sysfs.c
> 

When you add new sysfs entries, you have to also add new
Documentation/ABI/ entries.

thanks,

greg k-h