Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751531AbdFHSu3 (ORCPT ); Thu, 8 Jun 2017 14:50:29 -0400 Received: from www.llwyncelyn.cymru ([82.70.14.225]:58112 "EHLO fuzix.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbdFHSu1 (ORCPT ); Thu, 8 Jun 2017 14:50:27 -0400 Date: Thu, 8 Jun 2017 19:50:05 +0100 From: Alan Cox To: Jason Gunthorpe Cc: "Shaikh, Azhar" , "jarkko.sakkinen@linux.intel.com" , "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "linux-security-module@vger.kernel.org" Subject: Re: [PATCH v3] tpm: Enable CLKRUN protocol for Braswell systems Message-ID: <20170608195005.6edc9242@lxorguk.ukuu.org.uk> In-Reply-To: <20170608183920.GA7984@obsidianresearch.com> References: <1496369044-38234-1-git-send-email-azhar.shaikh@intel.com> <1496870610-29462-1-git-send-email-azhar.shaikh@intel.com> <20170607224444.5043f545@lxorguk.ukuu.org.uk> <5FFFAD06ADE1CA4381B3F0F7C6AF5828910C7B@ORSMSX109.amr.corp.intel.com> <20170608192259.43150ffa@lxorguk.ukuu.org.uk> <20170608183920.GA7984@obsidianresearch.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 453 Lines: 10 > For that purpose all that should be required is strong ordering of the > outb relative to the other TPM commands at the LPC interface FIFO. I > also think the wmb is not needed because outb is already defined to be > strongly in order with respect to writel/readl ? That's my assumption but given this is all some kind of 'it's broken' fixup I thought best to ask. Assuming there is nothing else magical going on then yes it should be deleted. Alan