Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751675AbdFHT1k convert rfc822-to-8bit (ORCPT ); Thu, 8 Jun 2017 15:27:40 -0400 Received: from mga05.intel.com ([192.55.52.43]:59045 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583AbdFHT1g (ORCPT ); Thu, 8 Jun 2017 15:27:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,315,1493708400"; d="scan'208";a="96061928" From: "Shaikh, Azhar" To: Alan Cox , Jason Gunthorpe CC: "jarkko.sakkinen@linux.intel.com" , "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "linux-security-module@vger.kernel.org" Subject: RE: [PATCH v3] tpm: Enable CLKRUN protocol for Braswell systems Thread-Topic: [PATCH v3] tpm: Enable CLKRUN protocol for Braswell systems Thread-Index: AQHS39SiwJ4GDqs/JkyDneHONWNViaIaZDwA//+7DECAAZ7qgIAABJIAgAADAYD//45CoA== Date: Thu, 8 Jun 2017 19:27:34 +0000 Message-ID: <5FFFAD06ADE1CA4381B3F0F7C6AF5828910FC0@ORSMSX109.amr.corp.intel.com> References: <1496369044-38234-1-git-send-email-azhar.shaikh@intel.com> <1496870610-29462-1-git-send-email-azhar.shaikh@intel.com> <20170607224444.5043f545@lxorguk.ukuu.org.uk> <5FFFAD06ADE1CA4381B3F0F7C6AF5828910C7B@ORSMSX109.amr.corp.intel.com> <20170608192259.43150ffa@lxorguk.ukuu.org.uk> <20170608183920.GA7984@obsidianresearch.com> <20170608195005.6edc9242@lxorguk.ukuu.org.uk> In-Reply-To: <20170608195005.6edc9242@lxorguk.ukuu.org.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzc0ZjQ3YzItNmZmYy00M2QxLThlZTYtZjk2Y2YyOTZiMTYzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImJcL29aUFREZ3pTbStOaTFwaElGWUtLQ1RwSkhxejhBem5Mc1kyT2FXTTJJPSJ9 dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1029 Lines: 25 > -----Original Message----- > From: Alan Cox [mailto:gnomes@lxorguk.ukuu.org.uk] > Sent: Thursday, June 8, 2017 11:50 AM > To: Jason Gunthorpe > Cc: Shaikh, Azhar ; > jarkko.sakkinen@linux.intel.com; tpmdd-devel@lists.sourceforge.net; linux- > kernel@vger.kernel.org; linux-security-module@vger.kernel.org > Subject: Re: [PATCH v3] tpm: Enable CLKRUN protocol for Braswell systems > > > For that purpose all that should be required is strong ordering of the > > outb relative to the other TPM commands at the LPC interface FIFO. I > > also think the wmb is not needed because outb is already defined to be > > strongly in order with respect to writel/readl ? > > That's my assumption but given this is all some kind of 'it's broken' > fixup I thought best to ask. Assuming there is nothing else magical going on > then yes it should be deleted. > As Jason mentioned, outb is already define to be strongly ordered, then wmb is not needed. I will delete it. > Alan