Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751685AbdFHTk5 (ORCPT ); Thu, 8 Jun 2017 15:40:57 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:42051 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbdFHTk4 (ORCPT ); Thu, 8 Jun 2017 15:40:56 -0400 Date: Thu, 8 Jun 2017 21:40:54 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 5/7] net: dsa: mv88e6xxx: rework pause limit operation Message-ID: <20170608194054.GI20216@lunn.ch> References: <20170608190445.24443-1-vivien.didelot@savoirfairelinux.com> <20170608190445.24443-6-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170608190445.24443-6-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 677 Lines: 17 On Thu, Jun 08, 2017 at 03:04:43PM -0400, Vivien Didelot wrote: > All Marvell chips supporting Pause frames limiting use 1-byte value for > input and output. > > Old chips have both bytes adjacent in a 16-bit register. New ones have > an indirect table using 8-bit data. > > The mv88e6xxx library functions (such as in port.c) must not contain > driver logic, but only generic helpers. This patch changes the > port_pause_config operation for port_pause_limit taking two u8 arguments > for input and output limits. There is no functional changes. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew