Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751633AbdFHTwX (ORCPT ); Thu, 8 Jun 2017 15:52:23 -0400 Received: from gateway23.websitewelcome.com ([192.185.50.185]:19740 "EHLO gateway23.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751448AbdFHTwV (ORCPT ); Thu, 8 Jun 2017 15:52:21 -0400 Date: Thu, 08 Jun 2017 14:52:16 -0500 Message-ID: <20170608145216.Horde.bIht4FUMAG95aZaBJGbeFqj@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Dennis Dalessandro Cc: Mike Marciniszyn , Doug Ledford , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] IB/qib: remove duplicate code References: <20170607204202.GA29640@embeddedgus> In-Reply-To: User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1dJ3Tc-0009tu-VO X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:52456 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 1 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1147 Lines: 44 Hi Dennis, Quoting Dennis Dalessandro : > On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote: >> Remove duplicate code. >> >> Addresses-Coverity-ID: 1226951 >> Signed-off-by: Gustavo A. R. Silva >> --- >> drivers/infiniband/hw/qib/qib_mad.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/infiniband/hw/qib/qib_mad.c >> b/drivers/infiniband/hw/qib/qib_mad.c >> index da295e0..c5eaa3c 100644 >> --- a/drivers/infiniband/hw/qib/qib_mad.c >> +++ b/drivers/infiniband/hw/qib/qib_mad.c >> @@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp >> *smp, struct ib_device *ibdev, >> ib_dispatch_event(&event); >> } >> - ret = subn_get_portinfo(smp, ibdev, port); >> - >> /* restore re-reg bit per o14-12.2.1 */ >> pip->clientrereg_resv_subnetto |= clientrereg; >> > > Would be nice to see a few more words in the commit message rather > than having to go look for Coverity. > I'll take note of that. > Regardless, patch seems fine to me code wise. > > Reviewed-by: Dennis Dalessandro Thank you -- Gustavo A. R. Silva